Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/android/tab_android.cc

Issue 2284933002: Remove OfflineURL from offline page (Closed)
Patch Set: Fix trybot Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc ('K') | « chrome/browser/android/offline_pages/offline_page_utils_unittest.cc ('k') | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/tab_android.cc
diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc
index 63cbe9f53e5679bef3c7a9846e7ef3c0b89e8e5a..9cb337eb8b2eee3af3e8e0b601aa066cfd60e1bd 100644
--- a/chrome/browser/android/tab_android.cc
+++ b/chrome/browser/android/tab_android.cc
@@ -761,12 +761,6 @@ jlong TabAndroid::GetBookmarkId(JNIEnv* env,
web_contents()->GetURL());
Profile* profile = GetProfile();
- // If the url points to an offline page, then we need to get its original URL.
- if (offline_pages::OfflinePageUtils::IsOfflinePage(profile, url)) {
- url = offline_pages::OfflinePageUtils::MaybeGetOnlineURLForOfflineURL(
- profile, url);
- }
-
// Get all the nodes for |url| and sort them by date added.
std::vector<const bookmarks::BookmarkNode*> nodes;
bookmarks::ManagedBookmarkService* managed =
« chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc ('K') | « chrome/browser/android/offline_pages/offline_page_utils_unittest.cc ('k') | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698