Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1817)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2284933002: Remove OfflineURL from offline page (Closed)
Patch Set: Fix trybot Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index 6956113e5c7d4c63faca6ccd06cad64b9222d345..e5088bfed0360591423bee92ba2a9eb2ca880603 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -1025,15 +1025,14 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
ContentBitmapCallback callback = new ContentBitmapCallback() {
@Override
public void onFinishGetBitmap(Bitmap bitmap, int response) {
- boolean isOfflinePage = currentTab.isOfflinePage();
RecordHistogram.recordBooleanHistogram(
- "OfflinePages.SharedPageWasOffline", isOfflinePage);
+ "OfflinePages.SharedPageWasOffline", currentTab.isOfflinePage());
boolean canShareOfflinePage = OfflinePageBridge.isPageSharingEnabled();
if (canShareOfflinePage) {
// Share the offline page instead of the URL.
OfflinePageUtils.shareOfflinePage(shareDirectly, true, mainActivity, null,
- currentTab.getUrl(), bitmap, null, currentTab, isOfflinePage);
+ currentTab.getUrl(), bitmap, null, currentTab);
} else {
ShareHelper.share(shareDirectly, true, mainActivity, currentTab.getTitle(),
null, currentTab.getUrl(), null, bitmap, null);

Powered by Google App Engine
This is Rietveld 408576698