Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: media/filters/ffmpeg_demuxer_unittest.cc

Issue 2284923003: Implement support for multiple tracks in FFmpegDemuxer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/filters/ffmpeg_demuxer.cc ('K') | « media/filters/ffmpeg_demuxer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_demuxer_unittest.cc
diff --git a/media/filters/ffmpeg_demuxer_unittest.cc b/media/filters/ffmpeg_demuxer_unittest.cc
index 483feed3bf3e574f063fc428252451b8bc63084c..302c44ede1e06081c9d17199f3601c478e02124c 100644
--- a/media/filters/ffmpeg_demuxer_unittest.cc
+++ b/media/filters/ffmpeg_demuxer_unittest.cc
@@ -1260,6 +1260,41 @@ TEST_F(FFmpegDemuxerTest, Read_Mp4_Media_Track_Info) {
EXPECT_EQ(video_track.language(), "und");
}
+TEST_F(FFmpegDemuxerTest, Read_Mp4_Multiple_Tracks) {
+ CreateDemuxer("bbb-320x240-2video-2audio.mp4");
DaleCurtis 2016/08/29 18:15:21 mp4 clips are only tested in prop codecs builds wh
servolk 2016/08/29 18:38:21 Sure, I'll look into adding a webm test as well.
+ InitializeDemuxer();
+
+ EXPECT_EQ(media_tracks_->tracks().size(), 4u);
+
+ const MediaTrack& video_track = *(media_tracks_->tracks()[0]);
+ EXPECT_EQ(video_track.type(), MediaTrack::Video);
+ EXPECT_EQ(video_track.bytestream_track_id(), 1);
+ EXPECT_EQ(video_track.kind(), "main");
+ EXPECT_EQ(video_track.label(), "VideoHandler");
+ EXPECT_EQ(video_track.language(), "und");
+
+ const MediaTrack& audio_track = *(media_tracks_->tracks()[1]);
+ EXPECT_EQ(audio_track.type(), MediaTrack::Audio);
+ EXPECT_EQ(audio_track.bytestream_track_id(), 2);
+ EXPECT_EQ(audio_track.kind(), "main");
+ EXPECT_EQ(audio_track.label(), "SoundHandler");
+ EXPECT_EQ(audio_track.language(), "und");
+
+ const MediaTrack& video_track2 = *(media_tracks_->tracks()[2]);
+ EXPECT_EQ(video_track2.type(), MediaTrack::Video);
+ EXPECT_EQ(video_track2.bytestream_track_id(), 3);
+ EXPECT_EQ(video_track2.kind(), "main");
+ EXPECT_EQ(video_track2.label(), "VideoHandler");
+ EXPECT_EQ(video_track2.language(), "und");
+
+ const MediaTrack& audio_track2 = *(media_tracks_->tracks()[3]);
+ EXPECT_EQ(audio_track2.type(), MediaTrack::Audio);
+ EXPECT_EQ(audio_track2.bytestream_track_id(), 4);
+ EXPECT_EQ(audio_track2.kind(), "main");
+ EXPECT_EQ(audio_track2.label(), "SoundHandler");
+ EXPECT_EQ(audio_track2.language(), "und");
+}
+
#endif // defined(USE_PROPRIETARY_CODECS)
TEST_F(FFmpegDemuxerTest, Read_Webm_Media_Track_Info) {
« media/filters/ffmpeg_demuxer.cc ('K') | « media/filters/ffmpeg_demuxer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698