Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2284923002: Fix bug in locateSingleElement (Closed)

Created:
4 years, 3 months ago by sra1
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bug in locateSingleElement This bug probably did not show up much because the conditions that cause the bug also cause unimplemented interface method warnings. There is a degradation in code quality in mixin method bodies which I will address later. This bug is unrelated to the recent removal of the 'mask' parameter of locateSingleElement. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/f404301ec3cba3f14afbb4327ea76f07d9830275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -5 lines) Patch
M pkg/compiler/lib/src/types/flat_type_mask.dart View 1 chunk +7 lines, -5 lines 0 comments Download
A tests/compiler/dart2js_extra/locate_single_element_1_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
4 years, 3 months ago (2016-08-26 22:24:40 UTC) #3
Siggi Cherem (dart-lang)
lgtm!
4 years, 3 months ago (2016-08-26 22:42:28 UTC) #4
sra1
4 years, 3 months ago (2016-08-26 22:52:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f404301ec3cba3f14afbb4327ea76f07d9830275 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698