Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2284913002: chromium_android: Add device affinity to links (Closed)

Created:
4 years, 3 months ago by martiniss
Modified:
4 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

chromium_android: Add device affinity to links This is so that sheriff-o-matic has a more structured way to get the device affinity of a particular step. Recipe-Tryjob-Bypass-Reason: Downstream diffs expected Committed: https://chromium.googlesource.com/chromium/tools/build/+/cff87e6a98e85207aba12e0f73cc7bf7e779b002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -117 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/enable_platform_mode_basic.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/last_known_devices_basic.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_high_battery_temp_basic.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_low_battery_basic.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_basic.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_disable_location_basic.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_user_build_basic.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_tests_failure.json View 2 chunks +5 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_tests_infra_failure.json View 2 chunks +5 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/timestamp_as_point_id_basic.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/host_info_failure.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/missing_device.json View 2 chunks +5 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/src_side_script_fails.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/test_failure.json View 2 chunks +5 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__1_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__2_.json View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__3_.json View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
martiniss
PTAL For perf SOM. I was previously parsing the raw step text. Yay stringly type ...
4 years, 3 months ago (2016-08-26 22:16:20 UTC) #2
jbudorick
lgtm, though Device Affinity: 3 stdio device_affinity is going to look a little weird.
4 years, 3 months ago (2016-08-26 22:18:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284913002/1
4 years, 3 months ago (2016-08-26 22:20:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/cff87e6a98e85207aba12e0f73cc7bf7e779b002
4 years, 3 months ago (2016-08-26 22:24:42 UTC) #8
martiniss
4 years, 1 month ago (2016-11-18 00:07:22 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2511213003/ by martiniss@chromium.org.

The reason for reverting is: Ended up being harder to use than I thought. We use
step text for now :/.

Powered by Google App Engine
This is Rietveld 408576698