Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: include/ports/SkFontMgr.h

Issue 22849025: Implement SkEmptyFontMgr::onLegacyCreateTypeface and make pure virtual. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkFontHost.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/ports/SkFontMgr.h
===================================================================
--- include/ports/SkFontMgr.h (revision 10850)
+++ include/ports/SkFontMgr.h (working copy)
@@ -99,10 +99,7 @@
virtual SkTypeface* onCreateFromData(SkData*, int ttcIndex) = 0;
virtual SkTypeface* onCreateFromStream(SkStream*, int ttcIndex) = 0;
virtual SkTypeface* onCreateFromFile(const char path[], int ttcIndex) = 0;
-
- // TODO: make this pure-virtual once all ports know about it
- virtual SkTypeface* onLegacyCreateTypeface(const char familyName[],
- unsigned styleBits);
+ virtual SkTypeface* onLegacyCreateTypeface(const char familyName[], unsigned styleBits) = 0;
private:
static SkFontMgr* Factory(); // implemented by porting layer
« no previous file with comments | « no previous file | src/core/SkFontHost.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698