Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1926)

Unified Diff: chrome/browser/ui/webui/extensions/pack_extension_handler.cc

Issue 22849012: Update WebUI calls to use extensions namespace, update IDs in c/b/r/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change all HTML IDs in c/b/r/extensions to be in-hyphenated-case Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/pack_extension_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/pack_extension_handler.cc b/chrome/browser/ui/webui/extensions/pack_extension_handler.cc
index 765344690be2c7231aa8ef3c7bbb1e088ff066c1..4bb3e4e5370551c60db1d7c8cc2cfee09d12d5d7 100644
--- a/chrome/browser/ui/webui/extensions/pack_extension_handler.cc
+++ b/chrome/browser/ui/webui/extensions/pack_extension_handler.cc
@@ -73,7 +73,7 @@ void PackExtensionHandler::OnPackSuccess(const base::FilePath& crx_file,
UTF16ToUTF8(PackExtensionJob::StandardSuccessMessage(
crx_file, pem_file))));
web_ui()->CallJavascriptFunction(
- "PackExtensionOverlay.showSuccessMessage", arguments);
+ "extensions.PackExtensionOverlay.showSuccessMessage", arguments);
}
void PackExtensionHandler::OnPackFailure(const std::string& error,
@@ -85,8 +85,8 @@ void PackExtensionHandler::OnPackFailure(const std::string& error,
base::FundamentalValue overwrite_flag(ExtensionCreator::kOverwriteCRX);
web_ui()->CallJavascriptFunction(
- "ExtensionSettings.askToOverrideWarning", error_str, extension_path_str,
- key_path_str, overwrite_flag);
+ "extensions.ExtensionSettings.askToOverrideWarning",
+ error_str, extension_path_str, key_path_str, overwrite_flag);
} else {
ShowAlert(error);
}
@@ -202,7 +202,8 @@ void PackExtensionHandler::HandleSelectFilePathMessage(
void PackExtensionHandler::ShowAlert(const std::string& message) {
ListValue arguments;
arguments.Append(Value::CreateStringValue(message));
- web_ui()->CallJavascriptFunction("PackExtensionOverlay.showError", arguments);
+ web_ui()->CallJavascriptFunction(
+ "extensions.PackExtensionOverlay.showError", arguments);
}
} // namespace extensions
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698