chrome/browser/ui/webui/extensions/extension_settings_browsertest.js - Issue 22849012: Update WebUI calls to use extensions namespace, update IDs in c/b/r/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

Issue 22849012: Update WebUI calls to use extensions namespace, update IDs in c/b/r/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change all HTML IDs in c/b/r/extensions to be in-hyphenated-case Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/extensions/command_handler.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

index ed1f622ab5c6ca72703205abab730406ef2c59ef..8b403198fd591312fc6eb06caf6222a0a5e7d1ed 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

+++ b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

@@ -26,11 +26,11 @@ TEST_F('ExtensionSettingsWebUITest', 'testChromeSendHandled', function() {

assertEquals(this.browsePreload, document.location.href);

// This dialog should be hidden at first.

- assertFalse($('packExtensionOverlay').classList.contains('showing'));

+ assertFalse($('pack-extension-overlay').classList.contains('showing'));

// Show the dialog, which triggers a chrome.send() for metrics purposes.

cr.dispatchSimpleEvent($('pack-extension'), 'click');

- assertTrue($('packExtensionOverlay').classList.contains('showing'));

+ assertTrue($('pack-extension-overlay').classList.contains('showing'));

});

/**

@@ -55,5 +55,5 @@ TEST_F('ExtensionSettingsCommandsConfigWebUITest', 'testChromeSendHandler',

function() {

// Just navigating to the page should trigger the chrome.send().

assertEquals(this.browsePreload, document.location.href);

- assertTrue($('extensionCommandsOverlay').classList.contains('showing'));

+ assertTrue($('extension-commands-overlay').classList.contains('showing'));

});