Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: chrome/browser/resources/extensions/pack_extension_overlay.js

Issue 22849012: Update WebUI calls to use extensions namespace, update IDs in c/b/r/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change all HTML IDs in c/b/r/extensions to be in-hyphenated-case Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/pack_extension_overlay.js
diff --git a/chrome/browser/resources/extensions/pack_extension_overlay.js b/chrome/browser/resources/extensions/pack_extension_overlay.js
index e4b9f0d1c3d78634008a2e80c431001eed2c1450..22a316501525994545f0585d458331f709dd9408 100644
--- a/chrome/browser/resources/extensions/pack_extension_overlay.js
+++ b/chrome/browser/resources/extensions/pack_extension_overlay.js
@@ -23,13 +23,13 @@ cr.define('extensions', function() {
cr.ui.overlay.globalInitialization();
overlay.addEventListener('cancelOverlay', this.handleDismiss_.bind(this));
- $('packExtensionDismiss').addEventListener('click',
+ $('pack-extension-dismiss').addEventListener('click',
this.handleDismiss_.bind(this));
- $('packExtensionCommit').addEventListener('click',
+ $('pack-extension-commit').addEventListener('click',
this.handleCommit_.bind(this));
- $('browseExtensionDir').addEventListener('click',
+ $('browse-extension-dir').addEventListener('click',
this.handleBrowseExtensionDir_.bind(this));
- $('browsePrivateKey').addEventListener('click',
+ $('browse-private-key').addEventListener('click',
this.handleBrowsePrivateKey_.bind(this));
},
@@ -38,7 +38,7 @@ cr.define('extensions', function() {
* @param {Event} e The click event.
*/
handleDismiss_: function(e) {
- ExtensionSettings.showOverlay(null);
+ extensions.ExtensionSettings.showOverlay(null);
},
/**
@@ -46,8 +46,8 @@ cr.define('extensions', function() {
* @param {Event} e The click event.
*/
handleCommit_: function(e) {
- var extensionPath = $('extensionRootDir').value;
- var privateKeyPath = $('extensionPrivateKey').value;
+ var extensionPath = $('extension-root-dir').value;
+ var privateKeyPath = $('extension-private-key').value;
chrome.send('pack', [extensionPath, privateKeyPath, 0]);
},
@@ -75,7 +75,7 @@ cr.define('extensions', function() {
*/
handleBrowseExtensionDir_: function(e) {
this.showFileDialog_('folder', 'load', function(filePath) {
- $('extensionRootDir').value = filePath;
+ $('extension-root-dir').value = filePath;
});
},
@@ -86,7 +86,7 @@ cr.define('extensions', function() {
*/
handleBrowsePrivateKey_: function(e) {
this.showFileDialog_('file', 'pem', function(filePath) {
- $('extensionPrivateKey').value = filePath;
+ $('extension-private-key').value = filePath;
});
},
};
@@ -103,10 +103,10 @@ cr.define('extensions', function() {
loadTimeData.getString('ok'),
'',
function() {
- ExtensionSettings.showOverlay(null);
+ extensions.ExtensionSettings.showOverlay(null);
},
null);
- ExtensionSettings.showOverlay($('alertOverlay'));
+ extensions.ExtensionSettings.showOverlay($('alertOverlay'));
};
/**
@@ -120,10 +120,10 @@ cr.define('extensions', function() {
loadTimeData.getString('ok'),
'',
function() {
- ExtensionSettings.showOverlay($('packExtensionOverlay'));
+ extensions.ExtensionSettings.showOverlay($('pack-extension-overlay'));
},
null);
- ExtensionSettings.showOverlay($('alertOverlay'));
+ extensions.ExtensionSettings.showOverlay($('alertOverlay'));
};
// Export
@@ -131,6 +131,3 @@ cr.define('extensions', function() {
PackExtensionOverlay: PackExtensionOverlay
};
});
-
-// Update the C++ call so this isn't necessary.
-var PackExtensionOverlay = extensions.PackExtensionOverlay;
« no previous file with comments | « chrome/browser/resources/extensions/pack_extension_overlay.html ('k') | chrome/browser/ui/webui/extensions/command_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698