Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2284893002: ozone: Remove primary plane optimization. (Closed)

Created:
4 years, 3 months ago by Daniele Castagna
Modified:
4 years, 3 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org, ccameron
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Remove primary plane optimization. Chrome browser compositor sends the primary buffer as a normal overlay, therefore the optimization to replace the primary plane can be done earlier in the browser compositor (crrev.com/2281033003). This CL removes the optimization in Ozone. BUG=b/29430506 Committed: https://crrev.com/5ab9e3dcf31799d15a4449abd00c3c2d34263fbe Cr-Commit-Position: refs/heads/master@{#415169}

Patch Set 1 #

Patch Set 2 : Remove unittest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -54 lines) Patch
M ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc View 1 1 chunk +0 lines, -25 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc View 3 chunks +0 lines, -29 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
Daniele Castagna
We moved the primary plane optimization in the chrome browser compositor: crrev.com/2281033003. The problem we ...
4 years, 3 months ago (2016-08-29 20:28:27 UTC) #7
dnicoara
lgtm ... This is awesome! Thank you for getting rid of the workarounds in Ozone.
4 years, 3 months ago (2016-08-29 20:42:01 UTC) #8
Daniele Castagna
ccing ccameron and halliwell: FYI, in case this is used anywhere I'm not aware of.
4 years, 3 months ago (2016-08-29 22:40:44 UTC) #10
halliwell
On 2016/08/29 22:40:44, Daniele Castagna wrote: > ccing ccameron and halliwell: FYI, in case this ...
4 years, 3 months ago (2016-08-29 22:43:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284893002/20001
4 years, 3 months ago (2016-08-30 01:01:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284893002/20001
4 years, 3 months ago (2016-08-30 02:03:07 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 05:39:51 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:43:09 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ab9e3dcf31799d15a4449abd00c3c2d34263fbe
Cr-Commit-Position: refs/heads/master@{#415169}

Powered by Google App Engine
This is Rietveld 408576698