|
|
Created:
4 years, 3 months ago by Daniele Castagna Modified:
4 years, 3 months ago Reviewers:
dnicoara CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org, ccameron Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionozone: Remove primary plane optimization.
Chrome browser compositor sends the primary buffer as a
normal overlay, therefore the optimization to replace the
primary plane can be done earlier in the browser compositor (crrev.com/2281033003).
This CL removes the optimization in Ozone.
BUG=b/29430506
Committed: https://crrev.com/5ab9e3dcf31799d15a4449abd00c3c2d34263fbe
Cr-Commit-Position: refs/heads/master@{#415169}
Patch Set 1 #Patch Set 2 : Remove unittest. #
Messages
Total messages: 22 (14 generated)
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== ozone: Remove primary plane optimization. BUG=b/29430506 ========== to ========== ozone: Remove primary plane optimization. Chrome browser compositor sends the primary buffer as a normal overlay, therefore the optimization to replace the primary plane can be done earlier in the browser compositor (crrev.com/2281033003). This CL removes the optimization in Ozone. BUG=b/29430506 ==========
dcastagna@chromium.org changed reviewers: + dnicoara@chromium.org
We moved the primary plane optimization in the chrome browser compositor: crrev.com/2281033003. The problem we found is that if there is a crtc that supports only one plane, ozone would reject the configuration of two fullscreen planes because the optimization would happen after checking if there are available planes. This optimization in ozone is no longer needed. What do you think about getting rid of it? If you want to leave it, I'll just send you another CL that cleans up all the hacks I added.
lgtm ... This is awesome! Thank you for getting rid of the workarounds in Ozone.
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
ccing ccameron and halliwell: FYI, in case this is used anywhere I'm not aware of.
On 2016/08/29 22:40:44, Daniele Castagna wrote: > ccing ccameron and halliwell: FYI, in case this is used anywhere I'm not aware > of. we don't use ozone drm platform ... so it's fine for us.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dcastagna@chromium.org
The CQ bit was checked by dcastagna@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dnicoara@chromium.org Link to the patchset: https://codereview.chromium.org/2284893002/#ps20001 (title: "Remove unittest.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dcastagna@chromium.org
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== ozone: Remove primary plane optimization. Chrome browser compositor sends the primary buffer as a normal overlay, therefore the optimization to replace the primary plane can be done earlier in the browser compositor (crrev.com/2281033003). This CL removes the optimization in Ozone. BUG=b/29430506 ========== to ========== ozone: Remove primary plane optimization. Chrome browser compositor sends the primary buffer as a normal overlay, therefore the optimization to replace the primary plane can be done earlier in the browser compositor (crrev.com/2281033003). This CL removes the optimization in Ozone. BUG=b/29430506 Committed: https://crrev.com/5ab9e3dcf31799d15a4449abd00c3c2d34263fbe Cr-Commit-Position: refs/heads/master@{#415169} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5ab9e3dcf31799d15a4449abd00c3c2d34263fbe Cr-Commit-Position: refs/heads/master@{#415169} |