Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2284843002: Fix nullptr dereference in service catalog (Closed)

Created:
4 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix nullptr dereference in service catalog ProcessManifest can return null in a few failure modes. This result gets passed into Reader::OnReadManifest which was doing no null checking. This fixes that. BUG=632916 TBR=ben@chromium.org Committed: https://crrev.com/3d1a0f65aa799880b017881b5b5e0f14e958cb74 Cr-Commit-Position: refs/heads/master@{#414769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M services/catalog/reader.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284843002/1
4 years, 3 months ago (2016-08-26 17:56:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 18:56:58 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 19:16:37 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d1a0f65aa799880b017881b5b5e0f14e958cb74
Cr-Commit-Position: refs/heads/master@{#414769}

Powered by Google App Engine
This is Rietveld 408576698