Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: src/transitions.h

Issue 228483005: Bugfix: A TransitionArray can disappear during copy. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Missing line. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/transitions.h
diff --git a/src/transitions.h b/src/transitions.h
index 6ee2f8660eac16d2559dc5642332824e6756b15e..70c57eafb1b4415584de0ddc304987b947aef6ca 100644
--- a/src/transitions.h
+++ b/src/transitions.h
@@ -96,19 +96,21 @@ class TransitionArray: public FixedArray {
inline int number_of_entries() { return number_of_transitions(); }
// Allocate a new transition array with a single entry.
- static Handle<TransitionArray> NewWith(SimpleTransitionFlag flag,
- Handle<Name> key,
+ static Handle<TransitionArray> NewWith(Handle<Map> map,
+ Handle<Name> name,
Handle<Map> target,
- Handle<Object> back_pointer);
+ SimpleTransitionFlag flag);
MUST_USE_RESULT MaybeObject* ExtendToFullTransitionArray();
- // Copy the transition array, inserting a new transition.
+ // Create a transition array, copying from the owning map if it already has
+ // one, otherwise creating a new one according to flag.
// TODO(verwaest): This should not cause an existing transition to be
// overwritten.
- static Handle<TransitionArray> CopyInsert(Handle<Map> map,
- Handle<Name> name,
- Handle<Map> target);
+ static Handle<TransitionArray> AddTransition(Handle<Map> map,
+ Handle<Name> name,
+ Handle<Map> target,
+ SimpleTransitionFlag flag);
// Copy a single transition from the origin array.
inline void NoIncrementalWriteBarrierCopyFrom(TransitionArray* origin,

Powered by Google App Engine
This is Rietveld 408576698