Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Side by Side Diff: chrome/test/data/webui/settings/languages_page_browsertest.js

Issue 2284823002: Mark SettingsLanguagesPageBrowserTest.LanguagesPage flaky on Windows (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** @fileoverview Suite of tests for settings-languages-page. */ 5 /** @fileoverview Suite of tests for settings-languages-page. */
6 6
7 /** @const {string} Path to root from chrome/test/data/webui/settings/. */ 7 /** @const {string} Path to root from chrome/test/data/webui/settings/. */
8 var ROOT_PATH = '../../../../../'; 8 var ROOT_PATH = '../../../../../';
9 9
10 // Polymer BrowserTest fixture. 10 // Polymer BrowserTest fixture.
(...skipping 13 matching lines...) Expand all
24 SettingsLanguagesPageBrowserTest.prototype = { 24 SettingsLanguagesPageBrowserTest.prototype = {
25 __proto__: SettingsPageBrowserTest.prototype, 25 __proto__: SettingsPageBrowserTest.prototype,
26 26
27 /** @override */ 27 /** @override */
28 preLoad: function() { 28 preLoad: function() {
29 SettingsPageBrowserTest.prototype.preLoad.call(this); 29 SettingsPageBrowserTest.prototype.preLoad.call(this);
30 settingsHidePagesByDefaultForTest = true; 30 settingsHidePagesByDefaultForTest = true;
31 }, 31 },
32 }; 32 };
33 33
34 // Flaky on Windows. See https://crbug.com/641400.
34 // May time out on debug builders and memory bots because 35 // May time out on debug builders and memory bots because
35 // the Settings page can take several seconds to load in a Release build 36 // the Settings page can take several seconds to load in a Release build
36 // and several times that in a Debug build. See https://crbug.com/558434. 37 // and several times that in a Debug build. See https://crbug.com/558434.
37 GEN('#if defined(MEMORY_SANITIZER) || !defined(NDEBUG)'); 38 GEN('#if defined(OS_WINDOWS) || defined(MEMORY_SANITIZER) || !defined(NDEBUG)');
38 GEN('#define MAYBE_LanguagesPage DISABLED_LanguagesPage'); 39 GEN('#define MAYBE_LanguagesPage DISABLED_LanguagesPage');
39 GEN('#else'); 40 GEN('#else');
40 GEN('#define MAYBE_LanguagesPage LanguagesPage'); 41 GEN('#define MAYBE_LanguagesPage LanguagesPage');
41 GEN('#endif'); 42 GEN('#endif');
42 43
43 // Runs languages page tests. 44 // Runs languages page tests.
44 TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() { 45 TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {
45 suite('languages page', function() { 46 suite('languages page', function() {
46 testing.Test.disableAnimationsAndTransitions(); 47 testing.Test.disableAnimationsAndTransitions();
47 48
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 assertTrue(!!languagesPage.$$('settings-edit-dictionary-page')); 278 assertTrue(!!languagesPage.$$('settings-edit-dictionary-page'));
278 } 279 }
279 }); 280 });
280 }.bind(this)); 281 }.bind(this));
281 282
282 // TODO(michaelpg): Test more aspects of the languages UI. 283 // TODO(michaelpg): Test more aspects of the languages UI.
283 284
284 // Run all registered tests. 285 // Run all registered tests.
285 mocha.run(); 286 mocha.run();
286 }); 287 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698