Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: tools/testing/dart/compiler_configuration.dart

Issue 2284793002: Pass the flag in test_suite. I'm not super familiar with this code, but I'm (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library compiler_configuration; 5 library compiler_configuration;
6 6
7 import 'dart:io' show Platform; 7 import 'dart:io' show Platform;
8 8
9 import 'runtime_configuration.dart' show RuntimeConfiguration; 9 import 'runtime_configuration.dart' show RuntimeConfiguration;
10 10
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 } 296 }
297 297
298 CommandArtifact computeCompilationArtifact( 298 CommandArtifact computeCompilationArtifact(
299 String buildDir, 299 String buildDir,
300 String tempDir, 300 String tempDir,
301 CommandBuilder commandBuilder, 301 CommandBuilder commandBuilder,
302 List arguments, 302 List arguments,
303 Map<String, String> environmentOverrides) { 303 Map<String, String> environmentOverrides) {
304 List compilerArguments = new List.from(arguments) 304 List compilerArguments = new List.from(arguments)
305 ..addAll(extraDart2jsOptions); 305 ..addAll(extraDart2jsOptions);
306 if (useFastStartup) {
307 compilerArguments.add('--fast-startup');
308 }
309 return new CommandArtifact(<Command>[ 306 return new CommandArtifact(<Command>[
310 this.computeCompilationCommand('$tempDir/out.js', buildDir, 307 this.computeCompilationCommand('$tempDir/out.js', buildDir,
311 CommandBuilder.instance, compilerArguments, environmentOverrides) 308 CommandBuilder.instance, compilerArguments, environmentOverrides)
312 ], '$tempDir/out.js', 'application/javascript'); 309 ], '$tempDir/out.js', 'application/javascript');
313 } 310 }
314 311
315 List<String> computeRuntimeArguments( 312 List<String> computeRuntimeArguments(
316 RuntimeConfiguration runtimeConfiguration, 313 RuntimeConfiguration runtimeConfiguration,
317 String buildDir, 314 String buildDir,
318 TestInformation info, 315 TestInformation info,
(...skipping 352 matching lines...) Expand 10 before | Expand all | Expand 10 after
671 RuntimeConfiguration runtimeConfiguration, 668 RuntimeConfiguration runtimeConfiguration,
672 String buildDir, 669 String buildDir,
673 TestInformation info, 670 TestInformation info,
674 List<String> vmOptions, 671 List<String> vmOptions,
675 List<String> sharedOptions, 672 List<String> sharedOptions,
676 List<String> originalArguments, 673 List<String> originalArguments,
677 CommandArtifact artifact) { 674 CommandArtifact artifact) {
678 return <String>[]; 675 return <String>[];
679 } 676 }
680 } 677 }
OLDNEW
« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698