Issue 2284793002: Pass the flag in test_suite. I'm not super familiar with this code, but I'm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2284793002: Pass the flag in test_suite. I'm not super familiar with this code, but I'm (Closed)

Created:
4 years, 3 months ago by Siggi Cherem (dart-lang)

Modified:
4 years, 3 months ago

Reviewers:
Bill Hesse, sra1

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Pass the flag in test_suite. I'm not super familiar with this code, but I'm copying what I see for the cps-ir flag. Turns out we were not passing the flag when running the html tests. BUG= Committed: https://github.com/dart-lang/sdk/commit/6b3357d848ab6513fd5e45ab9940906b2b097437

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/testing/dart/compiler_configuration.dart	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Siggi Cherem (dart-lang)

Committed patchset #1 (id:1) manually as 6b3357d848ab6513fd5e45ab9940906b2b097437 (presubmit successful).

4 years, 3 months ago (2016-08-26 17:19:54 UTC) #4

Message was sent while issue was closed.

lgtm