Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2284743003: more status updates: many tests that import mirrors also "pass" because they expect compile-time fa… (Closed)

Created:
4 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 3 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

more status updates: many tests that import mirrors also "pass" because they expect compile-time failures BUG= Committed: https://github.com/dart-lang/sdk/commit/2efdf57c92ecd87e50a1f3981ebaffdd51dcf573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -17 lines) Patch
M tests/co19/co19-dart2js.status View 2 chunks +63 lines, -14 lines 0 comments Download
M tests/language/language_dart2js.status View 3 chunks +7 lines, -3 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +17 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 2efdf57c92ecd87e50a1f3981ebaffdd51dcf573 (presubmit successful).
4 years, 3 months ago (2016-08-26 19:56:18 UTC) #2
Siggi Cherem (dart-lang)
TBR
4 years, 3 months ago (2016-08-26 20:00:33 UTC) #4
sra1
4 years, 3 months ago (2016-08-27 02:22:09 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698