Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Issue 2284713002: device/bluetooth: Fix copy constructor of BluetoothServiceAttributeValueBlueZ (Closed)

Created:
4 years, 3 months ago by Miao
Modified:
4 years, 3 months ago
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

device/bluetooth: Fix copy constructor of BluetoothServiceAttributeValueBlueZ The copy constructor was trying to call DeepCopy() against a nullptr. This adds a check if the type is NULLTYPE and return base::Value() if so. BUG=b:30963813 TEST=call the copy constructor with a NULLTYPE instance to see if it crashes Committed: https://crrev.com/4c369070c3e89056b3a90074315ac91b960862bf Cr-Commit-Position: refs/heads/master@{#414746}

Patch Set 1 #

Patch Set 2 : device/bluetooth: Fix copy constructor of BluetoothServiceAttributeValueBlueZ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Miao
Hello rkc@, can you help with reviewing? Thanks.
4 years, 3 months ago (2016-08-26 15:28:20 UTC) #4
Miao
4 years, 3 months ago (2016-08-26 15:28:39 UTC) #6
Rahul Chaturvedi
lgtm lgtm
4 years, 3 months ago (2016-08-26 17:10:25 UTC) #13
Rahul Chaturvedi
lgtm
4 years, 3 months ago (2016-08-26 17:10:26 UTC) #14
Rahul Chaturvedi
Double clicking on the quick lgtm button does that apparently.
4 years, 3 months ago (2016-08-26 17:11:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284713002/20001
4 years, 3 months ago (2016-08-26 17:35:42 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 18:00:36 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 18:12:58 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c369070c3e89056b3a90074315ac91b960862bf
Cr-Commit-Position: refs/heads/master@{#414746}

Powered by Google App Engine
This is Rietveld 408576698