Issue 22847004: Rename CustomElementUpgradeCandidateMap::DestructionObserverMap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22847004: Rename CustomElementUpgradeCandidateMap::DestructionObserverMap. (Closed)

Created:
7 years, 4 months ago by dominicc (has gone to gerrit)

Modified:
7 years, 4 months ago

Reviewers:
dglazkov, dglazkov1

CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rename CustomElementUpgradeCandidateMap::DestructionObserverMap. While they observe destruction, they more specifically observe *element* destruction, so rename this ElementObserverMap. This is both more specific and more flexible if this needs to observe other parts of the element lifecycle in future. BUG=234509 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156063

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -20 lines)			Patch
	M	Source/core/dom/CustomElementUpgradeCandidateMap.h	View		1 chunk	+10 lines, -7 lines	0 comments	Download
	M	Source/core/dom/CustomElementUpgradeCandidateMap.cpp	View		4 chunks	+13 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/22847004/1

7 years, 4 months ago (2013-08-13 22:56:42 UTC) #3

Message was sent while issue was closed.

Change committed as 156063

Expand Messages | Collapse Messages