Chromium Code Reviews Chromium Code Reviews
Issue 22847002:
Fix for crash occuring when spatial navigation is enabled (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/spatial-navigation/snav-date.html |
| diff --git a/LayoutTests/fast/spatial-navigation/snav-date.html b/LayoutTests/fast/spatial-navigation/snav-date.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..92ac7baa828cfdd284cc59ee47a24141963603ef |
| --- /dev/null |
| +++ b/LayoutTests/fast/spatial-navigation/snav-date.html |
| @@ -0,0 +1,59 @@ |
| +<!DOCTYPE html> |
| + <head> |
| + <script src="../js/resources/js-test-pre.js"></script> |
| + <script src="resources/spatial-navigation-utils.js"></script> |
| + <script> |
| + window.jsTestIsAsync = true; |
|
tkent
2013/08/25 22:11:36
Do not indent all of <script> content equally. Al
Krzysztof Olczyk
2013/08/28 08:13:01
Done.
|
| + |
| + if (window.testRunner) { |
| + testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1); |
|
tkent
2013/08/25 22:11:36
We usually use 4-space indentation in JavaScript c
Krzysztof Olczyk
2013/08/28 08:13:01
Done.
|
| + window.internals.settings.setSpatialNavigationEnabled(true); |
| + } |
| + </script> |
| + <script src="../js/resources/js-test-post.js"></script> |
| + </head> |
| + <body id="some-content" xmlns="http://www.w3.org/1999/xhtml"> |
| + <p id="description"></p> |
| + <table style="text-align: left; width: 100%; margin-left: auto; margin-right: auto;" border="1" cellpadding="2" cellspacing="1"> |
| + <tbody> |
| + <tr> |
| + <td style="vertical-align: top; text-align: center;"><a id="left" href="a">Left</a></td> |
| + <td style="vertical-align: top; text-align: center;"><input id="start" type="date" value="text"></td> |
| + <td style="vertical-align: top; text-align: center;"><a id="right" href="a">Right</a></td> |
| + </tr> |
| + </tbody> |
| + </table> |
| + <div id="console"></div> |
| + <script type="application/javascript"> |
| + description('This test ensures the correctness of Spatial Navigation (SNav) algorithm over date input element (having shadow DOM).<br>\ |
|
tkent
2013/08/25 22:11:36
Ditto for indentation.
Krzysztof Olczyk
2013/08/28 08:13:01
Done.
|
| + * Navigation steps:<br>\ |
| + 1) Loads this page, focus goes to "start" automatically.<br>\ |
| + 2) Focus moves away from input box, left and right to neighbor nodes and back.<br>'); |
| + |
| + var resultMap = [ |
| + ["Left", "left"], |
| + ["Right", "start"], // month |
| + ["Right", "start"], // day |
| + ["Right", "start"], // year |
| + ["Right", "right"], |
| + ["Left", "start"], |
| + ["DONE", "DONE"] |
| + ]; |
| + |
| + function runTest() |
| + { |
| + // starting the test itself: get to a known place. |
| + document.getElementById("start").focus(); |
| + |
| + initTest(resultMap, testCompleted); |
|
tkent
2013/08/25 22:11:36
testCompleted function is redundant. You can do
Krzysztof Olczyk
2013/08/28 08:13:01
Done.
|
| + } |
| + |
| + function testCompleted() |
| + { |
| + finishJSTest(); |
| + } |
| + |
| + window.onload = runTest; |
| + </script> |
| + </body> |
| +</html> |
