Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2284693003: Fix and enable WinAudioInputTest.WASAPIAudioInputStreamTestPacketSizes. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix and enable WinAudioInputTest.WASAPIAudioInputStreamTestPacketSizes. Contrary to what had been assumed, CheckCountAndPostQuitTask doesn't run on the main thread. Because of that, it cannot quit the RunLoop running on the main thread by calling its QuitWhenIdle function; it needs to post a QuitWhenIdleClosure to it. BUG=641142 Committed: https://crrev.com/7accaec8bb0f2bc5172e816370895b3e5cb1d874 Cr-Commit-Position: refs/heads/master@{#414783}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M media/audio/win/audio_low_latency_input_win_unittest.cc View 6 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
fdoray
PTAL
4 years, 3 months ago (2016-08-26 14:44:38 UTC) #2
DaleCurtis
lgtm
4 years, 3 months ago (2016-08-26 18:17:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284693003/1
4 years, 3 months ago (2016-08-26 18:19:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 19:42:52 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 19:45:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7accaec8bb0f2bc5172e816370895b3e5cb1d874
Cr-Commit-Position: refs/heads/master@{#414783}

Powered by Google App Engine
This is Rietveld 408576698