Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Unified Diff: src/frames-inl.h

Issue 2284673002: Fix LookupCode for the DatePrototype_GetField builtin (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/x87/builtins-x87.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames-inl.h
diff --git a/src/frames-inl.h b/src/frames-inl.h
index 77784b823459e478139363da86cd462e64782cf3..61d0dcd66374feb66bef36bae6e719a9d5ecc920 100644
--- a/src/frames-inl.h
+++ b/src/frames-inl.h
@@ -63,6 +63,8 @@ inline StackHandler* StackFrame::top_handler() const {
inline Code* StackFrame::LookupCode() const {
+ // TODO(jgruber): This should really check that pc is within the returned
+ // code's instruction range [instruction_start(), instruction_end()[.
return GetContainingCode(isolate(), pc());
}
« no previous file with comments | « src/builtins/x87/builtins-x87.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698