Fix LookupCode for the DatePrototype_GetField builtin

src/builtins/arm64/builtins-arm64.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if V8_TARGET_ARCH_ARM64
 
 #include "src/arm64/frames-arm64.h"
 #include "src/codegen.h"
 #include "src/debug/debug.h"
 #include "src/deoptimizer.h"
@@ skipping 1852 matching lines @@
   __ Ret();
 
   // 3. Raise a TypeError if the receiver is not a date.
   __ Bind(&receiver_not_date);
   {
     FrameScope scope(masm, StackFrame::MANUAL);
     __ Push(x0);
     __ Mov(x0, Smi::FromInt(0));
     __ EnterBuiltinFrame(cp, x1, x0);
     __ CallRuntime(Runtime::kThrowNotDateError);
+
+    // It's far from obvious, but this final trailing instruction after the call
+    // is required for StackFrame::LookupCode to work correctly. To illustrate
+    // why: if call were the final instruction in the code object, then the pc
+    // (== return address) would point beyond the code object when the stack is
+    // traversed. When we then try to look up the code object through
+    // StackFrame::LookupCode, we actually return the next code object that
+    // happens to be on the same page in memory.
+    // TODO(jgruber): A proper fix for this would be nice.
+    __ nop();
   }
 }
 
 // static
 void Builtins::Generate_FunctionPrototypeApply(MacroAssembler* masm) {
   // ----------- S t a t e -------------
   //  -- x0       : argc
   //  -- jssp[0]  : argArray (if argc == 2)
   //  -- jssp[8]  : thisArg  (if argc >= 1)
   //  -- jssp[16] : receiver
@@ skipping 1154 matching lines @@
     __ Unreachable();
   }
 }
 
 #undef __
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_ARM