Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2284633002: Allow multiple type and id selectors in invalidation set features. (Closed)

Created:
4 years, 3 months ago by rune
Modified:
4 years, 3 months ago
Reviewers:
sashab, Eric Willigers
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow multiple type and id selectors in invalidation set features. :-webkit-any allows for more than one type selector in a compound selector. Likewise, it may also allow for disjunct id selectors. Make them vectors in InvalidationSetFeatures like we do for classes and attributes to make style invalidation work for multiple id and type selectors in :-webkit-any. R=ericwilligers@chromium.org,sashab@chromium.org BUG=641296 Committed: https://crrev.com/38d4778dc4775085d9e7221cee7e8658942d748f Cr-Commit-Position: refs/heads/master@{#414933}

Patch Set 1 #

Patch Set 2 : Unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -8 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/webkit-any.html View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp View 1 3 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
rune
ptal
4 years, 3 months ago (2016-08-26 11:56:55 UTC) #2
Eric Willigers
lgtm
4 years, 3 months ago (2016-08-27 08:19:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284633002/20001
4 years, 3 months ago (2016-08-27 10:27:19 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-27 11:45:45 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/38d4778dc4775085d9e7221cee7e8658942d748f Cr-Commit-Position: refs/heads/master@{#414933}
4 years, 3 months ago (2016-08-27 11:47:49 UTC) #11
sashab
4 years, 3 months ago (2016-08-30 00:06:28 UTC) #12
Message was sent while issue was closed.
Sorry, late but better than never! Definitely LGTM! This is a super well-written
patch

Powered by Google App Engine
This is Rietveld 408576698