Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp

Issue 2284623002: Remove V8_CALL macro (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp
diff --git a/third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp b/third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp
index 475d6b6026646555c5ecb7032d55f26d7bc44124..be2b02d7da8a5fb5580edfcce0d96603c9d5fa2b 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp
+++ b/third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp
@@ -70,10 +70,7 @@ bool V8SQLStatementErrorCallback::handleEvent(SQLTransaction* transaction, SQLEr
// Jump to the last step in the overall steps.
if (!V8ScriptRunner::callFunction(m_callback.newLocal(isolate), getExecutionContext(), m_scriptState->context()->Global(), WTF_ARRAY_LENGTH(argv), argv, isolate).ToLocal(&result))
return true;
-
- bool value;
- V8_CALL(value, result, BooleanValue(isolate->GetCurrentContext()), return true);
- return value;
+ return value->BooleanValue(isolate->GetCurrentContext()).ToChecked();
Yuki 2016/08/26 15:25:01 s/value/result/ Did you compile the CL? |result|
haraken 2016/09/05 00:45:42 Done.
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698