Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2284593002: [wasm] Remove the Float(32|64)SubMinusZero tests. (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
titzer, balazs.kilvady
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove the Float(32|64)SubMinusZero tests. These tests became obsolete. They tested a requirement that has been removed from the WebAssembly specification. R=titzer@chromium.org, Balazs.Kilvady@imgtec.com Committed: https://crrev.com/25cdfd79a4a583344448f174c7165f480aee732e Cr-Commit-Position: refs/heads/master@{#38938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ahaas
4 years, 3 months ago (2016-08-26 09:08:17 UTC) #1
titzer
lgtm
4 years, 3 months ago (2016-08-26 09:14:01 UTC) #4
balazs.kilvady
LGTM , thanks.
4 years, 3 months ago (2016-08-26 09:25:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284593002/1
4 years, 3 months ago (2016-08-26 10:01:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 10:03:54 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 10:04:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25cdfd79a4a583344448f174c7165f480aee732e
Cr-Commit-Position: refs/heads/master@{#38938}

Powered by Google App Engine
This is Rietveld 408576698