Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8467)

Unified Diff: chrome/browser/ui/browser_navigator.cc

Issue 2284573004: Don't allow navigations in inactive windows to change window focus. (Closed)
Patch Set: Add more comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_navigator.cc
diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc
index 0e576c6c842afa53847b06442f745421955be814..1f60c7a16f2820200a192574fb1820b7e500a50b 100644
--- a/chrome/browser/ui/browser_navigator.cc
+++ b/chrome/browser/ui/browser_navigator.cc
@@ -554,9 +554,9 @@ void Navigate(NavigateParams* params) {
if (params->source_contents == params->target_contents ||
(swapped_in_prerender && params->disposition == CURRENT_TAB)) {
// The navigation occurred in the source tab.
- params->browser->UpdateUIForNavigationInTab(params->target_contents,
- params->transition,
- user_initiated);
+ params->browser->UpdateUIForNavigationInTab(
+ params->target_contents, params->transition, params->window_action,
+ user_initiated);
} else if (singleton_index == -1) {
// If some non-default value is set for the index, we should tell the
// TabStripModel to respect it.

Powered by Google App Engine
This is Rietveld 408576698