Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/browser/ui/browser.h

Issue 2284573004: Don't allow navigations in inactive windows to change window focus. (Closed)
Patch Set: Add more comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | chrome/test/base/web_ui_browser_test.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_H_
6 #define CHROME_BROWSER_UI_BROWSER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
11 #include <memory> 11 #include <memory>
12 #include <set> 12 #include <set>
13 #include <string> 13 #include <string>
14 #include <vector> 14 #include <vector>
15 15
16 #include "base/compiler_specific.h" 16 #include "base/compiler_specific.h"
17 #include "base/gtest_prod_util.h" 17 #include "base/gtest_prod_util.h"
18 #include "base/macros.h" 18 #include "base/macros.h"
19 #include "base/memory/weak_ptr.h" 19 #include "base/memory/weak_ptr.h"
20 #include "base/scoped_observer.h" 20 #include "base/scoped_observer.h"
21 #include "base/strings/string16.h" 21 #include "base/strings/string16.h"
22 #include "build/build_config.h" 22 #include "build/build_config.h"
23 #include "chrome/browser/devtools/devtools_toggle_action.h" 23 #include "chrome/browser/devtools/devtools_toggle_action.h"
24 #include "chrome/browser/ui/bookmarks/bookmark_bar.h" 24 #include "chrome/browser/ui/bookmarks/bookmark_bar.h"
25 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.h" 25 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.h"
26 #include "chrome/browser/ui/browser_navigator.h" 26 #include "chrome/browser/ui/browser_navigator.h"
27 #include "chrome/browser/ui/browser_navigator_params.h"
27 #include "chrome/browser/ui/chrome_bubble_manager.h" 28 #include "chrome/browser/ui/chrome_bubble_manager.h"
28 #include "chrome/browser/ui/chrome_web_modal_dialog_manager_delegate.h" 29 #include "chrome/browser/ui/chrome_web_modal_dialog_manager_delegate.h"
29 #include "chrome/browser/ui/exclusive_access/exclusive_access_manager.h" 30 #include "chrome/browser/ui/exclusive_access/exclusive_access_manager.h"
30 #include "chrome/browser/ui/profile_chooser_constants.h" 31 #include "chrome/browser/ui/profile_chooser_constants.h"
31 #include "chrome/browser/ui/search/search_tab_helper_delegate.h" 32 #include "chrome/browser/ui/search/search_tab_helper_delegate.h"
32 #include "chrome/browser/ui/signin_view_controller.h" 33 #include "chrome/browser/ui/signin_view_controller.h"
33 #include "chrome/browser/ui/tab_contents/core_tab_helper_delegate.h" 34 #include "chrome/browser/ui/tab_contents/core_tab_helper_delegate.h"
34 #include "chrome/browser/ui/tabs/tab_strip_model_observer.h" 35 #include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
35 #include "components/content_settings/core/common/content_settings.h" 36 #include "components/content_settings/core/common/content_settings.h"
36 #include "components/content_settings/core/common/content_settings_types.h" 37 #include "components/content_settings/core/common/content_settings_types.h"
(...skipping 359 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 void OpenFile(); 397 void OpenFile();
397 398
398 void UpdateDownloadShelfVisibility(bool visible); 399 void UpdateDownloadShelfVisibility(bool visible);
399 400
400 ///////////////////////////////////////////////////////////////////////////// 401 /////////////////////////////////////////////////////////////////////////////
401 402
402 // Called by chrome::Navigate() when a navigation has occurred in a tab in 403 // Called by chrome::Navigate() when a navigation has occurred in a tab in
403 // this Browser. Updates the UI for the start of this navigation. 404 // this Browser. Updates the UI for the start of this navigation.
404 void UpdateUIForNavigationInTab(content::WebContents* contents, 405 void UpdateUIForNavigationInTab(content::WebContents* contents,
405 ui::PageTransition transition, 406 ui::PageTransition transition,
407 chrome::NavigateParams::WindowAction action,
406 bool user_initiated); 408 bool user_initiated);
407 409
408 // Shows the signin flow for |mode| in a tab-modal dialog. 410 // Shows the signin flow for |mode| in a tab-modal dialog.
409 // |access_point| indicates the access point used to open the Gaia sign in 411 // |access_point| indicates the access point used to open the Gaia sign in
410 // page. 412 // page.
411 void ShowModalSigninWindow(profiles::BubbleViewMode mode, 413 void ShowModalSigninWindow(profiles::BubbleViewMode mode,
412 signin_metrics::AccessPoint access_point); 414 signin_metrics::AccessPoint access_point);
413 415
414 // Closes the tab-modal signin flow opened with ShowModalSigninWindow, if it's 416 // Closes the tab-modal signin flow opened with ShowModalSigninWindow, if it's
415 // open. Does nothing otherwise. 417 // open. Does nothing otherwise.
(...skipping 593 matching lines...) Expand 10 before | Expand all | Expand 10 after
1009 // The following factory is used for chrome update coalescing. 1011 // The following factory is used for chrome update coalescing.
1010 base::WeakPtrFactory<Browser> chrome_updater_factory_; 1012 base::WeakPtrFactory<Browser> chrome_updater_factory_;
1011 1013
1012 // The following factory is used to close the frame at a later time. 1014 // The following factory is used to close the frame at a later time.
1013 base::WeakPtrFactory<Browser> weak_factory_; 1015 base::WeakPtrFactory<Browser> weak_factory_;
1014 1016
1015 DISALLOW_COPY_AND_ASSIGN(Browser); 1017 DISALLOW_COPY_AND_ASSIGN(Browser);
1016 }; 1018 };
1017 1019
1018 #endif // CHROME_BROWSER_UI_BROWSER_H_ 1020 #endif // CHROME_BROWSER_UI_BROWSER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | chrome/test/base/web_ui_browser_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698