Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2284533002: Ensure FrameNavigationEntry is fully updated. (Closed)

Created:
4 years, 3 months ago by nasko
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Ensure FrameNavigationEntry is fully updated. Currently RendererDidNavigateToExistingPage and RendererDidNavigateToSamePage only partially update the FrameNavigationEntry for the committing navigation. This leads to inconsistency between sequence numbers and PageState, which can cause origin/URL mismatches. This CL updates both these methods to call AddOrUpdateFrameEntry to ensure that all members are properly updated. BUG=630103, 628677 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2224213005 Cr-Commit-Position: refs/heads/master@{#411224} (cherry picked from commit af18219268a332a92b3c8bbaa306aade92142c55) TBR=creis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/4ab88c96e291c275b3c0801aaffe13f124dd427d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -26 lines) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 3 chunks +21 lines, -24 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +60 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 1 chunk +25 lines, -1 line 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (3 generated)
nasko
4 years, 3 months ago (2016-08-26 01:19:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4ab88c96e291c275b3c0801aaffe13f124dd427d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698