Add bufferOutput to HttpServer, HttpResponse and HttpClientRequest.

sdk/lib/io/http.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 /**
  * HTTP status codes.
  */
 abstract class HttpStatus {
@@ skipping 157 matching lines @@
    *
    * Default is 120 seconds.
    *
    * Note that it may take up to `2 * idleTimeout` before a idle connection is
    * aborted.
    *
    * To disable, set [idleTimeout] to `null`.
    */
   Duration idleTimeout;
 
+
+  /**
+   * Get or set if the HttpServer should buffer output, by default.
+   *
+   * This setting is also changable at the individual [HttpResponse]s.
+   *
+   * Default is `true`.
+   *
+   * __Note__: Disabling buffering of the output can result in very poor
+   * performance, when writing many small chunks.
+   */
+  bool bufferOutput;

[Søren Gjesse, 2014/04/08 11:54:25]

Do we need this default? I assume this will only be set to false for specific
URLs.

[Anders Johnsen, 2014/04/08 12:40:07]

Good point. Will remove this one.

+
+
   /**
    * Starts listening for HTTP requests on the specified [address] and
    * [port].
    *
    * The [address] can either be a [String] or an
    * [InternetAddress]. If [address] is a [String], [bind] will
    * perform a [InternetAddress.lookup] and use the first value in the
    * list. To listen on the loopback adapter, which will allow only
    * incoming connections from the local host, use the value
    * [InternetAddress.LOOPBACK_IP_V4] or
@@ skipping 888 matching lines @@
    * When a deadline is exceeded, the response will be closed and any further
    * data ignored.
    *
    * To disable a deadline, set the [deadline] to `null`.
    *
    * The [deadline] is `null` by default.
    */
   Duration deadline;
 
   /**
+   * Get or set if the [HttpResponse] should buffer output.
+   *
+   * Default value is that of [HttpServer.bufferOutput].
+   *
+   * __Note__: Disabling buffering of the output can result in very poor
+   * performance, when writing many small chunks.
+   */
+  bool bufferOutput;
+
+  /**
    * Returns the response headers.
    *
    * The response headers can be modified until the response body is
    * written to or closed. After that they become immutable.
    */
   HttpHeaders get headers;
 
   /**
    * Cookies to set in the client (in the 'set-cookie' header).
    */
@@ skipping 461 matching lines @@
   Uri get uri;
 
   /**
    * Gets and sets the content length of the request. If the size of
    * the request is not known in advance set content length to -1,
    * which is also the default.
    */
   int contentLength;
 
   /**
+   * Get or set if the [HttpClientRequest] should buffer output.
+   *
+   * Default value is `true`.
+   *
+   * __Note__: Disabling buffering of the output can result in very poor
+   * performance, when writing many small chunks.
+   */
+  bool bufferOutput;
+
+  /**
    * Returns the client request headers.
    *
    * The client request headers can be modified until the client
    * request body is written to or closed. After that they become
    * immutable.
    */
   HttpHeaders get headers;
 
   /**
    * Cookies to present to the server (in the 'cookie' header).
@@ skipping 21 matching lines @@
 
 
 /**
  * HTTP response for a client connection.
 
  * The body of a [HttpClientResponse] object is a
  * [Stream] of data from the server. Listen to the body to handle
  * the data and be notified when the entire body is received.
  *
  *     new HttpClient().get('localhost', 80, '/file.txt')
- *          .then((HttpClientRequeset request) => request.close())
+ *          .then((HttpClientRequest request) => request.close())
  *          .then((HttpClientResponse response) {
  *            response.transform(UTF8.decoder).listen((contents) {
  *              // handle data
  *            });
  *          });
  */
 abstract class HttpClientResponse implements Stream<List<int>> {
   /**
    * Returns the status code.
    *
@@ skipping 193 matching lines @@
 class RedirectException implements HttpException {
   final String message;
   final List<RedirectInfo> redirects;
 
   const RedirectException(this.message, this.redirects);
 
   String toString() => "RedirectException: $message";
 
   Uri get uri => redirects.last.location;
 }