MD Downloads: fix search spinner when terms are the same

chrome/browser/resources/md_downloads/crisper.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 function assert(condition, opt_message) {
   if (!condition) {
     var message = 'Assertion failed';
     if (opt_message) message = message + ': ' + opt_message;
     var error = new Error(message);
     var global = function() {
       return this;
@@ skipping 2232 matching lines @@
     pause: chromeSendWithId('pause'),
     remove: chromeSendWithId('remove'),
     resume: chromeSendWithId('resume'),
     saveDangerous: chromeSendWithId('saveDangerous'),
     search: function(searchText) {
       var searchTerms = ActionService.splitTerms(searchText);
       var sameTerms = searchTerms.length == this.searchTerms_.length;
       for (var i = 0; sameTerms && i < searchTerms.length; ++i) {
         if (searchTerms[i] != this.searchTerms_[i]) sameTerms = false;
       }
-      if (sameTerms) return;
+      if (sameTerms) return false;
       this.searchTerms_ = searchTerms;
       this.loadMore();
+      return true;
     },
     show: chromeSendWithId('show'),
     undo: chrome.send.bind(chrome, 'undo')
   };
   cr.addSingletonGetter(ActionService);
   return {
     ActionService: ActionService
   };
 });
 
@@ skipping 4529 matching lines @@
       this.$.more.restoreFocusOnClose = false;
       this.closeMoreActions_();
       this.$.more.restoreFocusOnClose = true;
     },
     onPaperDropdownOpen_: function() {
       this.boundClose_ = this.boundClose_ || this.closeMoreActions_.bind(this);
       window.addEventListener('resize', this.boundClose_);
     },
     onSearchChanged_: function(event) {
       var actionService = downloads.ActionService.getInstance();
-      actionService.search(event.detail);
-      this.spinnerActive = actionService.isSearching();
+      if (actionService.search(event.detail)) this.spinnerActive = actionService.isSearching();
       this.updateClearAll_();
     },
     onOpenDownloadsFolderTap_: function() {
       downloads.ActionService.getInstance().openDownloadsFolder();
     },
     updateClearAll_: function() {
       this.$$('paper-menu .clear-all').hidden = !this.canClearAll();
     }
   });
   return {
@@ skipping 123 matching lines @@
   };
   return {
     Manager: Manager
   };
 });
 
 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 window.addEventListener('load', downloads.Manager.onLoad);