Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2284453002: Make compiles fail when __DATE__, __TIME__, or __TIMESTAMP_ are used. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 5e6d53095474bd9dcaaedf8b2d818170ffb79ed7..beacb49a5cb861fd3cacdde3880eab2f945cca2d 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -967,6 +967,9 @@ config("default_warnings") {
# Common Clang and GCC warning setup.
if (!is_win || is_clang) {
cflags += [
+ # Disable __DATE__ and __TIME__ to help make builds deterministic.
Nico 2016/08/25 19:20:03 Maybe add a note along the lines of "If this fires
+ "-Wdate-time",
+
# Disables.
"-Wno-missing-field-initializers", # "struct foo f = {0};"
"-Wno-unused-parameter", # Unused function parameters.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698