Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2284453002: Make compiles fail when __DATE__, __TIME__, or __TIMESTAMP_ are used. (Closed)
Patch Set: disable for nacl, improve comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 946 matching lines...) Expand 10 before | Expand all | Expand 10 after
957 # for gcc 4.8. 957 # for gcc 4.8.
958 # TODO: remove this flag once all builds work. See crbug.com/227506 958 # TODO: remove this flag once all builds work. See crbug.com/227506
959 cflags += [ "-Wno-unused-local-typedefs" ] 959 cflags += [ "-Wno-unused-local-typedefs" ]
960 960
961 # Don't warn about "maybe" uninitialized. Clang doesn't include this 961 # Don't warn about "maybe" uninitialized. Clang doesn't include this
962 # in -Wall but gcc does, and it gives false positives. 962 # in -Wall but gcc does, and it gives false positives.
963 cflags += [ "-Wno-maybe-uninitialized" ] 963 cflags += [ "-Wno-maybe-uninitialized" ]
964 } 964 }
965 } 965 }
966 966
967 if (!is_nacl && (!is_win || is_clang)) {
968 # Disable __DATE__ and __TIME__ to help make builds deterministic.
969 # Determinism is important, so we should fix compile failures rather
970 # than remove this flag (this is also why this is in :common_warnings
971 # rather than :chromium_code).
972 cflags += [ "-Wdate-time" ]
973 }
974
967 # Common Clang and GCC warning setup. 975 # Common Clang and GCC warning setup.
968 if (!is_win || is_clang) { 976 if (!is_win || is_clang) {
969 cflags += [ 977 cflags += [
970 # Disables. 978 # Disables.
971 "-Wno-missing-field-initializers", # "struct foo f = {0};" 979 "-Wno-missing-field-initializers", # "struct foo f = {0};"
972 "-Wno-unused-parameter", # Unused function parameters. 980 "-Wno-unused-parameter", # Unused function parameters.
973 ] 981 ]
974 } 982 }
975 983
976 if (is_chromeos) { 984 if (is_chromeos) {
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
1581 1589
1582 if (is_ios || is_mac) { 1590 if (is_ios || is_mac) {
1583 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1591 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1584 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1592 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1585 config("enable_arc") { 1593 config("enable_arc") {
1586 common_flags = [ "-fobjc-arc" ] 1594 common_flags = [ "-fobjc-arc" ]
1587 cflags_objc = common_flags 1595 cflags_objc = common_flags
1588 cflags_objcc = common_flags 1596 cflags_objcc = common_flags
1589 } 1597 }
1590 } 1598 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698