Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2284433002: Add missing includes (Closed)

Created:
4 years, 3 months ago by zra
Modified:
4 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing includes I am trying to get heap profiles from tcmalloc on MIPS. This appears to require compiling without -fno-exceptions. Removing that flag causes linker errors. This CL fixes the linker errors. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/c726e62565a4eb6b4aee4c44bea87f31101377b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/vm/megamorphic_cache_table.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/profiler_service.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 3 months ago (2016-08-25 18:35:05 UTC) #2
siva
lgtm
4 years, 3 months ago (2016-08-25 21:47:04 UTC) #3
zra
4 years, 3 months ago (2016-08-25 21:50:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c726e62565a4eb6b4aee4c44bea87f31101377b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698