Remove ChromiumSvnPoller

Remove ChromiumSvnPoller

This is unused now.

BUG=640212
Committed: https://chromium.googlesource.com/chromium/tools/build/+/a7625a98f986527265f39add33590853ddaaf761

[Michael Achenbach, 2016-08-29 09:48:54]

Description was changed from

==========
Remove ChromiumSvnPoller

BUG=
==========

to

==========
Remove ChromiumSvnPoller

This is unused now.

BUG=640212
==========

[Michael Achenbach, 2016-08-29 09:48:54]

machenbach@chromium.org changed reviewers:
+ agable@chromium.org, maruel@chromium.org, tandrii@chromium.org

[Michael Achenbach, 2016-08-29 09:49:59]

PTAL

[tandrii(chromium), 2016-08-29 10:37:03]

lgtm

Thanks

[Michael Achenbach, 2016-08-29 11:31:02]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-08-29 11:31:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 11:34:43]

Description was changed from

==========
Remove ChromiumSvnPoller

This is unused now.

BUG=640212
==========

to

==========
Remove ChromiumSvnPoller

This is unused now.

BUG=640212

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/a7625a98f986527265f3...
==========

[commit-bot: I haz the power, 2016-08-29 11:34:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/a7625a98f986527265f3...

[Sergey Berezin, 2016-08-30 21:28:59]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2294953002/ by sergeyberezin@chromium.org.

The reason for reverting is: This broke botmap_updater, because it is still used
by at least one official master - see http://crbug.com/642448 (internal only)..

[Michael Achenbach, 2016-08-31 07:08:15]

On 2016/08/30 21:28:59, Sergey Berezin wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2294953002/ by
mailto:sergeyberezin@chromium.org.
> 
> The reason for reverting is: This broke botmap_updater, because it is still
used
> by at least one official master - see http://crbug.com/642448 (internal
only)..

Strange, I could swear I did a "git grep chromium_svn_poller" in _up-to-date_
build_internal and build_limited.

[Michael Achenbach, 2016-08-31 07:09:54]

On 2016/08/31 07:08:15, machenbach (slow) wrote:
> On 2016/08/30 21:28:59, Sergey Berezin wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/2294953002/ by
> mailto:sergeyberezin@chromium.org.
> > 
> > The reason for reverting is: This broke botmap_updater, because it is still
> used
> > by at least one official master - see http://crbug.com/642448 (internal
> only)..
> 
> Strange, I could swear I did a "git grep chromium_svn_poller" in _up-to-date_
> build_internal and build_limited.

Meh, looked at my history. For whatever reason, in build_internal I did "git
grep ChromiumSvn".

Sorry for the trouble! I guess this can reland after the removal?

[Michael Achenbach, 2016-08-31 07:20:06]

On 2016/08/31 07:09:54, machenbach (slow) wrote:
> On 2016/08/31 07:08:15, machenbach (slow) wrote:
> > On 2016/08/30 21:28:59, Sergey Berezin wrote:
> > > A revert of this CL (patchset #1 id:1) has been created in
> > > https://codereview.chromium.org/2294953002/ by
> > mailto:sergeyberezin@chromium.org.
> > > 
> > > The reason for reverting is: This broke botmap_updater, because it is
still
> > used
> > > by at least one official master - see http://crbug.com/642448 (internal
> > only)..
> > 
> > Strange, I could swear I did a "git grep chromium_svn_poller" in
_up-to-date_
> > build_internal and build_limited.
> 
> Meh, looked at my history. For whatever reason, in build_internal I did "git
> grep ChromiumSvn".
> 
> Sorry for the trouble! I guess this can reland after the removal?

Never mind. Saw the revert never landed... bye bye ChromiumSvnPoller