components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h - Issue 2284393002: Add ClearHistory() to ContentSuggestionsService and its providers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

Issue 2284393002: Add ClearHistory() to ContentSuggestionsService and its providers (Closed)

Patch Set: Marc's comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc ('K') | « components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc ('k') | components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc » ('j') | components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

index ce8eeb571fed8b17ee9ebde38bc2527084d8c975..5ae37736762de428089e9eaa715a2fc7a16991ab 100644

--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

@@ -48,6 +48,7 @@ class PhysicalWebPageSuggestionsProvider : public ContentSuggestionsProvider {

void DismissSuggestion(const std::string& suggestion_id) override;

void FetchSuggestionImage(const std::string& suggestion_id,

const ImageFetchedCallback& callback) override;

+ void ClearHistory(base::Time begin, base::Time end) override;

void ClearCachedSuggestions(Category category) override;

void GetDismissedSuggestionsForDebugging(

Category category,