Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1444)

Unified Diff: components/ntp_snippets/content_suggestions_service.h

Issue 2284393002: Add ClearHistory() to ContentSuggestionsService and its providers (Closed)
Patch Set: Marc's comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_service.h
diff --git a/components/ntp_snippets/content_suggestions_service.h b/components/ntp_snippets/content_suggestions_service.h
index 4f36237e62bdf74c233655eb6a26fdb9d6baf6a8..22e768673b40ade51f990199cc5992517b8349b6 100644
--- a/components/ntp_snippets/content_suggestions_service.h
+++ b/components/ntp_snippets/content_suggestions_service.h
@@ -13,6 +13,7 @@
#include "base/callback_forward.h"
#include "base/observer_list.h"
#include "base/optional.h"
+#include "base/time/time.h"
#include "components/keyed_service/core/keyed_service.h"
#include "components/ntp_snippets/category_factory.h"
#include "components/ntp_snippets/category_status.h"
@@ -120,6 +121,14 @@ class ContentSuggestionsService : public KeyedService,
// called only once per provider.
void RegisterProvider(std::unique_ptr<ContentSuggestionsProvider> provider);
+ // Removes history from all providers from a given time range. The data
+ // removed depends on a provider. Note that the data outside the time range
+ // may be deleted, for example suggestions, which are based on the time range.
+ // Providers should immediately clear any specified time range history-related
+ // data, such as (possibly dismissed) suggestions for NTPSnippetsService or in
+ // case of BookmarkSuggestionsProvider last visit dates.
+ void ClearHistory(base::Time begin, base::Time end);
+
// Removes all suggestions from all caches or internal stores in all
// providers. See |ClearCachedSuggestions|.
void ClearAllCachedSuggestions();

Powered by Google App Engine
This is Rietveld 408576698