Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: components/ntp_snippets/content_suggestions_service.h

Issue 2284393002: Add ClearHistory() to ContentSuggestionsService and its providers (Closed)
Patch Set: msramek@'s comments and filter. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_service.h
diff --git a/components/ntp_snippets/content_suggestions_service.h b/components/ntp_snippets/content_suggestions_service.h
index bc8fb932473528d592b68b20f3d265351e4b1398..05ac915f4f7e9ef8dc0c07abc9da0a83c759accd 100644
--- a/components/ntp_snippets/content_suggestions_service.h
+++ b/components/ntp_snippets/content_suggestions_service.h
@@ -13,6 +13,7 @@
#include "base/callback_forward.h"
#include "base/observer_list.h"
#include "base/optional.h"
+#include "base/time/time.h"
#include "components/keyed_service/core/keyed_service.h"
#include "components/ntp_snippets/category_factory.h"
#include "components/ntp_snippets/category_status.h"
@@ -119,6 +120,16 @@ class ContentSuggestionsService : public KeyedService,
// called only once per provider.
void RegisterProvider(std::unique_ptr<ContentSuggestionsProvider> provider);
+ // Removes history from a given time range related to URLs matched by |filter|
+ // from all providers. The data removed depends on the provider. Note that the
+ // data outside the time range may be deleted, for example suggestions, which
+ // are based on history from that time range. Providers should immediately
+ // clear any data related to history from the specified time range and URLs
+ // matched by |filter|.
Marc Treib 2016/08/30 13:01:56 Same here
vitaliii 2016/08/30 14:17:48 Done.
+ void ClearHistory(base::Time begin,
+ base::Time end,
+ base::Callback<bool(const GURL& url)> filter);
+
// Removes all suggestions from all caches or internal stores in all
// providers. See |ClearCachedSuggestions|.
void ClearAllCachedSuggestions();

Powered by Google App Engine
This is Rietveld 408576698