Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2284373002: [turbofan] Instruction scheduler: keep ready nodes with same latency sorted in original order. (Closed)

Created:
4 years, 3 months ago by shiyu.zhang
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
Pan, Weiliang, chunyang.dai, tianyou.li
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Instruction scheduler: keep ready nodes with same latency sorted in original order. This is a complement to https://codereview.chromium.org/2281523002. The patch above reversed the order of nodes with same latency, which caused bench_copy.js 4% regression and bench_skinning.js 5% regression on Atom when enabling '--turbo-instruction-scheduling' flag according to our observation. We submit this patch to sort the nodes with same latency in original order. It aligns with instruction scheduling logic before the patch above and fixes these regression. BUG= Committed: https://crrev.com/3b083983d066034f4ead229cefcd27b622f7622f Cr-Commit-Position: refs/heads/master@{#39228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/instruction-scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
shiyu.zhang
PTAL
4 years, 3 months ago (2016-09-06 03:33:06 UTC) #4
Benedikt Meurer
Sorry for the delay, I missed this one. LGTM.
4 years, 3 months ago (2016-09-06 03:34:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284373002/1
4 years, 3 months ago (2016-09-07 01:33:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 02:11:56 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 02:12:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b083983d066034f4ead229cefcd27b622f7622f
Cr-Commit-Position: refs/heads/master@{#39228}

Powered by Google App Engine
This is Rietveld 408576698