Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2284343002: Convert editing/inserting/insert-br-at-tabspan-00[1-3].html to use w3c test harness (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/inserting/insert-br-at-tabspan-00[1-3].html to use w3c test harness This patch converts "editing/inserting/insert-br-at-tabspan-00[1-3].html" to use w3c test harness to simplify test script for improving readability, and consolidates into "insert_br_at_tabspan.html" since these files are in same patch at beginning. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/1cfde1fcc1ce96c66d2113a6318ddee1fcaf1e13 Cr-Commit-Position: refs/heads/master@{#415264}

Patch Set 1 : 2016-08-29T17:02:59 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -350 lines) Patch
D third_party/WebKit/LayoutTests/editing/inserting/insert-br-at-tabspan-001.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-br-at-tabspan-002.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-br-at-tabspan-003.html View 1 chunk +0 lines, -36 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/inserting/insert_br_at_tabspan.html View 1 chunk +58 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-at-tabspan-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-at-tabspan-001-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-at-tabspan-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-at-tabspan-002-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-at-tabspan-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-at-tabspan-003-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-at-tabspan-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-at-tabspan-001-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-at-tabspan-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-at-tabspan-002-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-at-tabspan-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-at-tabspan-001-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-at-tabspan-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-at-tabspan-002-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-at-tabspan-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-at-tabspan-003-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-08-29 09:33:39 UTC) #7
Xiaocheng
lgtm
4 years, 3 months ago (2016-08-30 08:22:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284343002/1
4 years, 3 months ago (2016-08-30 08:33:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 10:26:23 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 10:27:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cfde1fcc1ce96c66d2113a6318ddee1fcaf1e13
Cr-Commit-Position: refs/heads/master@{#415264}

Powered by Google App Engine
This is Rietveld 408576698