Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2284323002: Rename oddly-named PerformanceResourceTiming args (Closed)

Created:
4 years, 3 months ago by Adam Rice
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename oddly-named PerformanceResourceTiming args Some arguments to the PerformanceResourceTiming::create() methods have m_ prefixes, which makes them look like class members. Remove the m_ prefixes to reduce confusion. R=ksakamoto@chromium.org BUG= TEST=compiled Committed: https://crrev.com/836e5d0150b28e2987916098f551783735a9e2b2 Cr-Commit-Position: refs/heads/master@{#415611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Adam Rice
4 years, 3 months ago (2016-08-29 07:10:46 UTC) #2
Kunihiko Sakamoto
lgtm
4 years, 3 months ago (2016-08-29 07:26:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284323002/1
4 years, 3 months ago (2016-08-31 08:15:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/250082)
4 years, 3 months ago (2016-08-31 08:22:01 UTC) #10
Adam Rice
+kouhei for core OWNERS.
4 years, 3 months ago (2016-08-31 08:48:40 UTC) #12
kouhei (in TOK)
lgtm
4 years, 3 months ago (2016-08-31 11:31:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284323002/1
4 years, 3 months ago (2016-08-31 11:31:24 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 11:35:36 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 11:37:11 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/836e5d0150b28e2987916098f551783735a9e2b2
Cr-Commit-Position: refs/heads/master@{#415611}

Powered by Google App Engine
This is Rietveld 408576698