Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: src/full-codegen/full-codegen.h

Issue 2284313003: Separate CompilationInfo into its own file. (Closed)
Patch Set: fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/full-codegen.h
diff --git a/src/full-codegen/full-codegen.h b/src/full-codegen/full-codegen.h
index 370d16c37f46f718000818b50c9e3a062047d425..cb416662b617fadc0696aa363ac894f71078fe6b 100644
--- a/src/full-codegen/full-codegen.h
+++ b/src/full-codegen/full-codegen.h
@@ -8,12 +8,10 @@
#include "src/allocation.h"
#include "src/assert-scope.h"
#include "src/ast/ast.h"
-#include "src/ast/scopes.h"
#include "src/bit-vector.h"
#include "src/code-factory.h"
#include "src/code-stubs.h"
#include "src/codegen.h"
-#include "src/compiler.h"
#include "src/deoptimizer.h"
#include "src/globals.h"
#include "src/objects.h"
@@ -22,7 +20,10 @@ namespace v8 {
namespace internal {
// Forward declarations.
+class CompilationInfo;
+class CompilationJob;
class JumpPatchSite;
+class Scope;
// -----------------------------------------------------------------------------
// Full code generator.
@@ -30,38 +31,14 @@ class JumpPatchSite;
class FullCodeGenerator final : public AstVisitor<FullCodeGenerator> {
public:
FullCodeGenerator(MacroAssembler* masm, CompilationInfo* info,
- uintptr_t stack_limit)
- : masm_(masm),
- info_(info),
- isolate_(info->isolate()),
- zone_(info->zone()),
- scope_(info->scope()),
- nesting_stack_(NULL),
- loop_depth_(0),
- operand_stack_depth_(0),
- globals_(NULL),
- context_(NULL),
- bailout_entries_(info->HasDeoptimizationSupport()
- ? info->literal()->ast_node_count()
- : 0,
- info->zone()),
- back_edges_(2, info->zone()),
- handler_table_(info->zone()),
- source_position_table_builder_(info->zone(),
- info->SourcePositionRecordingMode()),
- ic_total_count_(0) {
- DCHECK(!info->IsStub());
- Initialize(stack_limit);
- }
+ uintptr_t stack_limit);
void Initialize(uintptr_t stack_limit);
static CompilationJob* NewCompilationJob(CompilationInfo* info);
static bool MakeCode(CompilationInfo* info, uintptr_t stack_limit);
- static bool MakeCode(CompilationInfo* info) {
- return MakeCode(info, info->isolate()->stack_guard()->real_climit());
- }
+ static bool MakeCode(CompilationInfo* info);
// Encode bailout state and pc-offset as a BitField<type, start, size>.
// Only use 30 bits because we encode the result as a smi.
@@ -701,10 +678,10 @@ class FullCodeGenerator final : public AstVisitor<FullCodeGenerator> {
Isolate* isolate() const { return isolate_; }
Zone* zone() const { return zone_; }
- Handle<Script> script() { return info_->script(); }
- LanguageMode language_mode() { return scope()->language_mode(); }
- bool has_simple_parameters() { return info_->has_simple_parameters(); }
- FunctionLiteral* literal() const { return info_->literal(); }
+ Handle<Script> script();
+ LanguageMode language_mode();
+ bool has_simple_parameters();
+ FunctionLiteral* literal() const;
Scope* scope() { return scope_; }
static Register context_register();
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698