Separate CompilationInfo into its own file.

Separate CompilationInfo into its own file.

This way, many files which only need CompilationInfo but not compiler.h
and its dependencies can include just compilation-info.h.

BUG=

Committed: https://crrev.com/06451354461ac0f323b9759092ba43f7d29c2af3
Cr-Commit-Position: refs/heads/master@{#39038}

[marja, 2016-08-29 09:49:04]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 09:49:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 09:50:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 09:50:36]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/11679)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/7807)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22769)

[marja, 2016-08-29 10:46:52]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 10:47:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 10:50:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 10:50:14]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/7812)

[marja, 2016-08-29 11:01:35]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 11:01:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 11:41:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 11:41:11]

Dry run: This issue passed the CQ dry run.

[marja, 2016-08-29 11:43:02]

marja@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[marja, 2016-08-29 11:43:03]

mstarzinger@, ptal

[marja, 2016-08-29 12:16:51]

Description was changed from

==========
Separate CompilationInfo into its own file.

This way, many files which only need CompilationInfo but not compiler.h
and its dependencies can include just compilation-info.h.

BUG=
==========

to

==========
Separate CompilationInfo into its own file.

This way, many files which only need CompilationInfo but not compiler.h
and its dependencies can include just compilation-info.h.

BUG=
==========

[marja, 2016-08-29 12:16:51]

marja@chromium.org changed reviewers:
+ verwaest@chromium.org
- mstarzinger@chromium.org

[marja, 2016-08-30 07:58:07]

marja@chromium.org changed reviewers:
+ bmeurer@chromium.org, titzer@chromium.org

[marja, 2016-08-30 07:58:08]

bmeurer@, titzer@, could you review?

git cl owners says:

bmeurer:
  src/compiler/arm/code-generator-arm.cc
  src/compiler/arm64/code-generator-arm64.cc
  src/compiler/ast-graph-builder.cc
  src/compiler/ast-loop-assignment-analyzer.cc
  src/compiler/basic-block-instrumentor.cc
  src/compiler/bytecode-graph-builder.cc
  src/compiler/bytecode-graph-builder.h
  src/compiler/code-generator.cc
  src/compiler/code-generator.h
  src/compiler/graph-visualizer.cc
  src/compiler/ia32/code-generator-ia32.cc
  src/compiler/js-inlining-heuristic.cc
  src/compiler/js-inlining.cc
  src/compiler/linkage.cc
  src/compiler/mips/code-generator-mips.cc
  src/compiler/mips64/code-generator-mips64.cc
  src/compiler/osr.cc
  src/compiler/pipeline-statistics.cc
  src/compiler/pipeline.cc
  src/compiler/ppc/code-generator-ppc.cc
  src/compiler/s390/code-generator-s390.cc
  src/compiler/wasm-compiler.h
  src/compiler/x64/code-generator-x64.cc
  src/compiler/x87/code-generator-x87.cc
  src/crankshaft/compilation-phase.h
  src/crankshaft/hydrogen.h
  src/crankshaft/lithium-codegen.cc
  src/crankshaft/lithium-codegen.h
  src/debug/debug-scopes.cc
  src/full-codegen/arm/full-codegen-arm.cc
  src/full-codegen/arm64/full-codegen-arm64.cc
  src/full-codegen/full-codegen.cc
  src/full-codegen/full-codegen.h
  src/full-codegen/ia32/full-codegen-ia32.cc
  src/full-codegen/mips/full-codegen-mips.cc
  src/full-codegen/mips64/full-codegen-mips64.cc
  src/full-codegen/ppc/full-codegen-ppc.cc
  src/full-codegen/s390/full-codegen-s390.cc
  src/full-codegen/x64/full-codegen-x64.cc
  src/full-codegen/x87/full-codegen-x87.cc
  src/ic/ic-inl.h
  src/interpreter/bytecode-array-builder.cc
  src/interpreter/bytecode-generator.cc
  src/interpreter/interpreter.cc
titzer:
  src/compiler/arm/code-generator-arm.cc
  src/compiler/arm64/code-generator-arm64.cc
  src/compiler/ast-graph-builder.cc
  src/compiler/ast-loop-assignment-analyzer.cc
  src/compiler/basic-block-instrumentor.cc
  src/compiler/bytecode-graph-builder.cc
  src/compiler/bytecode-graph-builder.h
  src/compiler/code-generator.cc
  src/compiler/code-generator.h
  src/compiler/graph-visualizer.cc
  src/compiler/ia32/code-generator-ia32.cc
  src/compiler/js-inlining-heuristic.cc
  src/compiler/js-inlining.cc
  src/compiler/linkage.cc
  src/compiler/mips/code-generator-mips.cc
  src/compiler/mips64/code-generator-mips64.cc
  src/compiler/osr.cc
  src/compiler/pipeline-statistics.cc
  src/compiler/pipeline.cc
  src/compiler/ppc/code-generator-ppc.cc
  src/compiler/s390/code-generator-s390.cc
  src/compiler/wasm-compiler.h
  src/compiler/x64/code-generator-x64.cc
  src/compiler/x87/code-generator-x87.cc
  src/wasm/wasm-js.cc

[titzer, 2016-08-31 07:55:15]

On 2016/08/30 07:58:08, marja wrote:
> bmeurer@, titzer@, could you review?
> 
> git cl owners says:
> 
> bmeurer:
>   src/compiler/arm/code-generator-arm.cc
>   src/compiler/arm64/code-generator-arm64.cc
>   src/compiler/ast-graph-builder.cc
>   src/compiler/ast-loop-assignment-analyzer.cc
>   src/compiler/basic-block-instrumentor.cc
>   src/compiler/bytecode-graph-builder.cc
>   src/compiler/bytecode-graph-builder.h
>   src/compiler/code-generator.cc
>   src/compiler/code-generator.h
>   src/compiler/graph-visualizer.cc
>   src/compiler/ia32/code-generator-ia32.cc
>   src/compiler/js-inlining-heuristic.cc
>   src/compiler/js-inlining.cc
>   src/compiler/linkage.cc
>   src/compiler/mips/code-generator-mips.cc
>   src/compiler/mips64/code-generator-mips64.cc
>   src/compiler/osr.cc
>   src/compiler/pipeline-statistics.cc
>   src/compiler/pipeline.cc
>   src/compiler/ppc/code-generator-ppc.cc
>   src/compiler/s390/code-generator-s390.cc
>   src/compiler/wasm-compiler.h
>   src/compiler/x64/code-generator-x64.cc
>   src/compiler/x87/code-generator-x87.cc
>   src/crankshaft/compilation-phase.h
>   src/crankshaft/hydrogen.h
>   src/crankshaft/lithium-codegen.cc
>   src/crankshaft/lithium-codegen.h
>   src/debug/debug-scopes.cc
>   src/full-codegen/arm/full-codegen-arm.cc
>   src/full-codegen/arm64/full-codegen-arm64.cc
>   src/full-codegen/full-codegen.cc
>   src/full-codegen/full-codegen.h
>   src/full-codegen/ia32/full-codegen-ia32.cc
>   src/full-codegen/mips/full-codegen-mips.cc
>   src/full-codegen/mips64/full-codegen-mips64.cc
>   src/full-codegen/ppc/full-codegen-ppc.cc
>   src/full-codegen/s390/full-codegen-s390.cc
>   src/full-codegen/x64/full-codegen-x64.cc
>   src/full-codegen/x87/full-codegen-x87.cc
>   src/ic/ic-inl.h
>   src/interpreter/bytecode-array-builder.cc
>   src/interpreter/bytecode-generator.cc
>   src/interpreter/interpreter.cc
> titzer:
>   src/compiler/arm/code-generator-arm.cc
>   src/compiler/arm64/code-generator-arm64.cc
>   src/compiler/ast-graph-builder.cc
>   src/compiler/ast-loop-assignment-analyzer.cc
>   src/compiler/basic-block-instrumentor.cc
>   src/compiler/bytecode-graph-builder.cc
>   src/compiler/bytecode-graph-builder.h
>   src/compiler/code-generator.cc
>   src/compiler/code-generator.h
>   src/compiler/graph-visualizer.cc
>   src/compiler/ia32/code-generator-ia32.cc
>   src/compiler/js-inlining-heuristic.cc
>   src/compiler/js-inlining.cc
>   src/compiler/linkage.cc
>   src/compiler/mips/code-generator-mips.cc
>   src/compiler/mips64/code-generator-mips64.cc
>   src/compiler/osr.cc
>   src/compiler/pipeline-statistics.cc
>   src/compiler/pipeline.cc
>   src/compiler/ppc/code-generator-ppc.cc
>   src/compiler/s390/code-generator-s390.cc
>   src/compiler/wasm-compiler.h
>   src/compiler/x64/code-generator-x64.cc
>   src/compiler/x87/code-generator-x87.cc
>   src/wasm/wasm-js.cc

lgtm

[Benedikt Meurer, 2016-08-31 07:56:18]

Very nice! LGTM.

[marja, 2016-08-31 07:57:48]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2016-08-31 07:57:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 08:49:21]

Description was changed from

==========
Separate CompilationInfo into its own file.

This way, many files which only need CompilationInfo but not compiler.h
and its dependencies can include just compilation-info.h.

BUG=
==========

to

==========
Separate CompilationInfo into its own file.

This way, many files which only need CompilationInfo but not compiler.h
and its dependencies can include just compilation-info.h.

BUG=
==========

[commit-bot: I haz the power, 2016-08-31 08:49:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-31 08:50:09]

Description was changed from

==========
Separate CompilationInfo into its own file.

This way, many files which only need CompilationInfo but not compiler.h
and its dependencies can include just compilation-info.h.

BUG=
==========

to

==========
Separate CompilationInfo into its own file.

This way, many files which only need CompilationInfo but not compiler.h
and its dependencies can include just compilation-info.h.

BUG=

Committed: https://crrev.com/06451354461ac0f323b9759092ba43f7d29c2af3
Cr-Commit-Position: refs/heads/master@{#39038}
==========

[commit-bot: I haz the power, 2016-08-31 08:50:10]

Patchset 3 (id:??) landed as
https://crrev.com/06451354461ac0f323b9759092ba43f7d29c2af3
Cr-Commit-Position: refs/heads/master@{#39038}

[Michael Starzinger, 2016-09-05 09:11:28]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-09-05 09:11:29]

LGTM.