Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2284303002: (WIP) ServiceWorker: Remove unnecessary WorkerThread::terminateAndWait() call

Created:
4 years, 3 months ago by nhiroki
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Remove unnecessary WorkerThread::terminateAndWait() call This CL removes WorkerThread::terminateAndWait() call from the dtor of WebEmbeddedWorkerImpl. WorkerThread should already be terminated or should not be started yet at the point. What if the owner of WebEmbeddedWorkerImpl (ie. EmbeddedWorkerDispatcher) is destroyed before the worker thread is terminated. This is not a matter because it possibly happened on graceful renderer process shutdown but we already abondoned the sequence: https://crbug.com/639244 BUG=641846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 3 chunks +15 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (6 generated)
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-08-29 05:16:00 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284303002/1
4 years, 3 months ago (2016-08-29 05:16:25 UTC) #2
nhiroki
Description was changed from ========== ServiceWorker: Remove unnecessary WorkerThread::terminateAndWait() call This CL removes WorkerThread::terminateAndWait() call ...
4 years, 3 months ago (2016-08-29 05:34:24 UTC) #3
nhiroki
Description was changed from ========== ServiceWorker: Remove unnecessary WorkerThread::terminateAndWait() call This CL removes WorkerThread::terminateAndWait() call ...
4 years, 3 months ago (2016-08-29 05:35:25 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-08-29 06:25:27 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 06:25:28 UTC) #6
Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698