Add $ref support to policy schema

components/policy/core/common/generate_policy_source_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "components/policy/core/common/policy_details.h"
@@ skipping 65 matching lines @@
   };
   const char** next = kExpectedProperties;
   for (Schema::Iterator it(subschema.GetPropertiesIterator());
        !it.IsAtEnd(); it.Advance(), ++next) {
     ASSERT_TRUE(*next != NULL);
     EXPECT_STREQ(*next, it.key());
     ASSERT_TRUE(it.schema().valid());
     EXPECT_EQ(base::Value::TYPE_STRING, it.schema().type());
   }
   EXPECT_TRUE(*next == NULL);
+
+#if defined(OS_CHROMEOS)
+  subschema = schema.GetKnownProperty(key::kPowerManagementIdleSettings);
+  ASSERT_TRUE(subschema.valid());
+
+  subschema = subschema.GetKnownProperty("Battery");
+  ASSERT_TRUE(subschema.valid());
+
+  subschema = subschema.GetKnownProperty("Delays");
+  ASSERT_TRUE(subschema.valid());
+
+  EXPECT_TRUE(subschema.GetKnownProperty("ScreenDim").valid());
+  EXPECT_TRUE(subschema.GetKnownProperty("ScreenOff").valid());
+  EXPECT_TRUE(subschema.GetKnownProperty("IdleWarning").valid());
+  EXPECT_TRUE(subschema.GetKnownProperty("Idle").valid());

[Joao da Silva, 2014/04/08 15:02:10]

Let's have a more strict test for this: check that GetKnownProperty("Battery")
equals GetKnownProperty("Delays"). You'll need to add a helper function in this
test that compares if two Schema objects are the same.

2 Schema objects are equal if:
- they are both invalid, OR:
  - they have the same type(), AND:
    - if the type() is LIST, then the schemas from GetItems() are equal too
    - if the type() is DICTIONARY, then:
      - have 2 iterators and iterate both at the same time; at each step they
must have equal keys and schemas
      -  GetAdditionalProperties() is also equal (maybe both are invalid)

[binjin, 2014/04/09 11:00:36]

Done.

+#endif
 }
 
 TEST(GeneratePolicySource, PolicyDetails) {
   EXPECT_FALSE(GetChromePolicyDetails(""));
   EXPECT_FALSE(GetChromePolicyDetails("no such policy"));
   EXPECT_FALSE(GetChromePolicyDetails("SearchSuggestEnable"));
   EXPECT_FALSE(GetChromePolicyDetails("searchSuggestEnabled"));
   EXPECT_FALSE(GetChromePolicyDetails("SSearchSuggestEnabled"));
 
   const PolicyDetails* details =
@@ skipping 20 matching lines @@
   EXPECT_TRUE(details->is_device_policy);
   EXPECT_EQ(90, details->id);
   EXPECT_EQ(0u, details->max_external_data_size);
 #endif
 
   // TODO(bartfab): add a test that verifies a max_external_data_size larger
   // than 0, once a type 'external' policy is added.
 }
 
 }  // namespace policy