LayoutTests/fast/dom/Element/setAttributeNode-for-existing-attribute.html - Issue 22842013: setAttributeNode() does not set the new value to an existing attribute if specified attribute is in…

Side by Side Diff: LayoutTests/fast/dom/Element/setAttributeNode-for-existing-attribute.html

Issue 22842013: setAttributeNode() does not set the new value to an existing attribute if specified attribute is in… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added layout testcases for XML and HTML documents Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../js/resources/js-test-pre.js"></script>

	5 <script>

	6 function getBackgroundStyle(id) {

	7 return document.getElementById(id).style.background;

	8 }

	9 function getAttributesLength(id) {

	10 return document.getElementById(id).attributes.length;

	11 }

	12 function runTest() {

	13 description('Testcase for bug <a href="http://crbug.com/279193">279193</a>: setAttributeNode() does not set the new value to an existing attribute if specif ied attribute is in a different case.\nThe issue can be manually verified by asc ertaining that a green colored block is displayed instead of a red one.');

	14

	15 var testElement = document.getElementById('test');

	16 var newAttr = document.createAttribute("STYLE");

	17 newAttr.value = "background-color: green;";

	18 testElement.setAttributeNode(newAttr);

	19

	20 shouldBe("getAttributesLength('test')", '2');
	arv (Not doing code reviews) 2013/08/29 13:45:21 Why not? shouldBe('testElement.attributes.length' Why not? shouldBe('testElement.attributes.length', '2'); and shouldBeEqualToString('testElement.style.background', 'green'); Your functions are only used once and do not add anything for readability. arpitab_ 2013/08/29 14:11:01 Done. Show quoted text On 2013/08/29 13:45:21, arv wrote: > Why not? > > shouldBe('testElement.attributes.length', '2'); > > and > > shouldBeEqualToString('testElement.style.background', 'green'); > > Your functions are only used once and do not add anything for readability. Done.
	21 shouldBe("getBackgroundStyle('test')", "'green'");

	22

	23 testElement.style.display = 'none';

	24 isSuccessfullyParsed();
	arv (Not doing code reviews) 2013/08/29 13:45:21 remove remove arpitab_ 2013/08/29 14:11:01 Done. Show quoted text On 2013/08/29 13:45:21, arv wrote: > remove Done.
	25 }

	26 </script>

	27 </head>

	28 <body onload="runTest();">
	arv (Not doing code reviews) 2013/08/29 13:45:21 remove onload and move the script block to after t remove onload and move the script block to after the testElement. arpitab_ 2013/08/29 14:11:01 Done. Show quoted text On 2013/08/29 13:45:21, arv wrote: > remove onload and move the script block to after the testElement. Done.
	29 <div id="description"></div>
	arv (Not doing code reviews) 2013/08/29 13:45:21 remove remove arpitab_ 2013/08/29 14:11:01 Done. Show quoted text On 2013/08/29 13:45:21, arv wrote: > remove Done.
	30 <div id="test" style="background-color: red;"/> </div>

	31 <div id="console"></div>
	arv (Not doing code reviews) 2013/08/29 13:45:21 remove remove arpitab_ 2013/08/29 14:11:01 Done. Show quoted text On 2013/08/29 13:45:21, arv wrote: > remove Done.
	32 </body>
	arv (Not doing code reviews) 2013/08/29 13:45:21 Missing <script src="../../js/resources/js-test- Missing <script src="../../js/resources/js-test-post.js"></script> arpitab_ 2013/08/29 14:11:01 Done. Show quoted text On 2013/08/29 13:45:21, arv wrote: > Missing > > <script src="../../js/resources/js-test-post.js"></script> Done.
	33 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Element/setAttributeNode-for-existing-attribute-expected.txt » ('j') | no next file with comments »