Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: native_client_sdk/src/tools/common.mk

Issue 22842011: [NaCl SDK] Remove invalid assert from nacl_io. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/tools/common.mk
diff --git a/native_client_sdk/src/tools/common.mk b/native_client_sdk/src/tools/common.mk
index 4fc67e68f4b9c6bef002e8d39ab32f2ed1cee245..6182faa4b1821b98b7fff30c39a713048528c094 100644
--- a/native_client_sdk/src/tools/common.mk
+++ b/native_client_sdk/src/tools/common.mk
@@ -284,8 +284,11 @@ endif
#
# Common Compile Options
#
+# For example, -DNDEBUG is added to release builds by default
+# so that calls to assert(3) are not included in the build.
+#
ifeq ($(CONFIG),Release)
-POSIX_FLAGS ?= -g -O2 -pthread -MMD
+POSIX_FLAGS ?= -g -O2 -pthread -MMD -DNDEBUG
else
POSIX_FLAGS ?= -g -O0 -pthread -MMD -DNACL_SDK_DEBUG
endif
« no previous file with comments | « native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc ('k') | native_client_sdk/src/tools/host_vc.mk » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698