[NaCl SDK] Remove invalid assert from nacl_io.

native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "nacl_io/kernel_proxy.h"
 
 
 #include <assert.h>
 #include <errno.h>
 #include <fcntl.h>
@@ skipping 67 matching lines @@
   // Clean up the MountFactories.
   for (MountFactoryMap_t::iterator i = factories_.begin();
        i != factories_.end();
        ++i) {
     delete i->second;
   }
 
   delete ppapi_;
 }
 
-void KernelProxy::Init(PepperInterface* ppapi) {
+Error KernelProxy::Init(PepperInterface* ppapi) {
+  Error rtn = 0;
   ppapi_ = ppapi;
   dev_ = 1;
 
   factories_["memfs"] = new TypedMountFactory<MountMem>;
   factories_["dev"] = new TypedMountFactory<MountDev>;
   factories_["html5fs"] = new TypedMountFactory<MountHtml5Fs>;
   factories_["httpfs"] = new TypedMountFactory<MountHttp>;
   factories_["passthroughfs"] = new TypedMountFactory<MountPassthrough>;
 
   int result;
   result = mount("", "/", "passthroughfs", 0, NULL);
   assert(result == 0);
+  if (result != 0)

[binji, 2013/08/24 01:35:57]

maybe use assert(false) inside the if instead?

+    rtn = errno;
 
   result = mount("", "/dev", "dev", 0, NULL);
   assert(result == 0);
+  if (result != 0)
+    rtn = errno;
 
   // Open the first three in order to get STDIN, STDOUT, STDERR
-  open("/dev/stdin", O_RDONLY);
-  open("/dev/stdout", O_WRONLY);
-  open("/dev/stderr", O_WRONLY);
+  int fd;
+  fd = open("/dev/stdin", O_RDONLY);
+  assert(fd == 0);
+  fd = open("/dev/stdout", O_WRONLY);
+  assert(fd == 1);
+  fd = open("/dev/stderr", O_WRONLY);
+  assert(fd == 2);
 
 #ifdef PROVIDES_SOCKET_API
   host_resolver_.Init(ppapi_);
 #endif
 
   StringMap_t args;
   socket_mount_.reset(new MountSocket());
-  socket_mount_->Init(0, args, ppapi);
+  result = socket_mount_->Init(0, args, ppapi);
+  assert(result == 0);
+  if (result != 0)
+    rtn = result;
+
+  return rtn;
 }
 
 int KernelProxy::open_resource(const char* path) {
   ScopedMount mnt;
   Path rel;
 
   Error error = AcquireMountAndRelPath(path, &mnt, &rel);
   if (error) {
     errno = error;
     return -1;
@@ skipping 1241 matching lines @@
     errno = ENOTSOCK;
     return -1;
   }
 
   return 0;
 }
 
 #endif  // PROVIDES_SOCKET_API
 
 }  // namespace_nacl_io