Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2284133002: [MD settings] align font size with quick brown fox example text (Closed)

Created:
4 years, 3 months ago by dschuyler
Modified:
4 years, 3 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] align font size with quick brown fox example text This CL puts the font size and example text in the same span so that they get properly aligned and wrapped. The effect (the bug or fix) is noticeable with huge font sizes (48 pt and higher). BUG=613203 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d9ff6c423ef8b4c369ab362863fe091c5ed5f057 Cr-Commit-Position: refs/heads/master@{#415117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html View 4 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dschuyler
4 years, 3 months ago (2016-08-27 01:06:42 UTC) #5
hcarmona
lgtm
4 years, 3 months ago (2016-08-27 01:16:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284133002/1
4 years, 3 months ago (2016-08-30 00:59:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 04:49:54 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:53:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9ff6c423ef8b4c369ab362863fe091c5ed5f057
Cr-Commit-Position: refs/heads/master@{#415117}

Powered by Google App Engine
This is Rietveld 408576698