Add performance tests for long words/lines

Add performance tests for long words/lines

This patch adds performance tests for:

1. To watch break-all/break-word performance for a very long word,
   which required several fixes in the past.

2. To investigate whitespace collapsing in a long line.

For 1, a test[1] indicates we're linear to the length of the word, but
Gecko/Edge looks consistent and faster than us.

For 2, we're slower than Gecko/Edge by the factor of 10 or so when the
line is very long. I will investigate it further.

[1] http://bl.ocks.org/stestagg/aa6db5d177b09e74825c6e4b02cb3f07

BUG=622810, 583711
Committed: https://crrev.com/1b56d7b9d53d796b72659d6ea0a70044a74c67ca
Cr-Commit-Position: refs/heads/master@{#415092}

[kojii, 2016-08-29 11:22:26]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 11:22:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 13:03:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 13:04:00]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-08-29 13:52:30]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 13:52:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-08-29 14:57:22]

Description was changed from

==========
perftest

BUG=
==========

to

==========
Add performance tests for long word/line

This patch adds performance tests for:

1. To watch break-all/break-word performance for a very long word,
   which required several fixes in the past.

2. To investigate whitespace collapsing in a long line.

For 1, a test[1] indicates we're linear to the length of the word, but
Gecko/Edge looks consistent and faster than us.

For 2, we're slower than Gecko/Edge by the factor of 10 or so when the
line is very long. I will investigate it further.

[1] http://bl.ocks.org/stestagg/aa6db5d177b09e74825c6e4b02cb3f07

BUG=622810, 583711
==========

[kojii, 2016-08-29 14:57:22]

Description was changed from

==========
perftest

BUG=
==========

to

==========
Add performance tests for long word/line

This patch adds performance tests for:

1. To watch break-all/break-word performance for a very long word,
   which required several fixes in the past.

2. To investigate whitespace collapsing in a long line.

For 1, a test[1] indicates we're linear to the length of the word, but
Gecko/Edge looks consistent and faster than us.

For 2, we're slower than Gecko/Edge by the factor of 10 or so when the
line is very long. I will investigate it further.

[1] http://bl.ocks.org/stestagg/aa6db5d177b09e74825c6e4b02cb3f07

BUG=622810, 583711
==========

[kojii, 2016-08-29 14:57:38]

kojii@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org

[kojii, 2016-08-29 14:57:39]

PTAL.

[commit-bot: I haz the power, 2016-08-29 15:05:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 15:05:45]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-08-29 15:36:16]

Description was changed from

==========
Add performance tests for long word/line

This patch adds performance tests for:

1. To watch break-all/break-word performance for a very long word,
   which required several fixes in the past.

2. To investigate whitespace collapsing in a long line.

For 1, a test[1] indicates we're linear to the length of the word, but
Gecko/Edge looks consistent and faster than us.

For 2, we're slower than Gecko/Edge by the factor of 10 or so when the
line is very long. I will investigate it further.

[1] http://bl.ocks.org/stestagg/aa6db5d177b09e74825c6e4b02cb3f07

BUG=622810, 583711
==========

to

==========
Add performance tests for long words/lines

This patch adds performance tests for:

1. To watch break-all/break-word performance for a very long word,
   which required several fixes in the past.

2. To investigate whitespace collapsing in a long line.

For 1, a test[1] indicates we're linear to the length of the word, but
Gecko/Edge looks consistent and faster than us.

For 2, we're slower than Gecko/Edge by the factor of 10 or so when the
line is very long. I will investigate it further.

[1] http://bl.ocks.org/stestagg/aa6db5d177b09e74825c6e4b02cb3f07

BUG=622810, 583711
==========

[eae, 2016-08-29 16:32:57]

LGTM

https://codereview.chromium.org/2284113003/diff/40001/third_party/WebKit/Perf...
File
third_party/WebKit/PerformanceTests/Layout/resources/line-layout-perf-test.js
(right):

https://codereview.chromium.org/2284113003/diff/40001/third_party/WebKit/Perf...
third_party/WebKit/PerformanceTests/Layout/resources/line-layout-perf-test.js:36:
this.container.removeChild(this.container.firstChild);
It's faster the remove the lastChild (but keep checking for firstChild in the
loop condition).

https://codereview.chromium.org/2284113003/diff/40001/third_party/WebKit/Perf...
third_party/WebKit/PerformanceTests/Layout/resources/line-layout-perf-test.js:69:
var fragment = document.createDocumentFragment();
Any particular reason you're using a document fragment instead of a container
element? Just curious.

[kojii, 2016-08-29 19:14:49]

The CQ bit was checked by kojii@chromium.org

[kojii, 2016-08-29 19:14:51]

Thank you for the review.

https://codereview.chromium.org/2284113003/diff/40001/third_party/WebKit/Perf...
File
third_party/WebKit/PerformanceTests/Layout/resources/line-layout-perf-test.js
(right):

https://codereview.chromium.org/2284113003/diff/40001/third_party/WebKit/Perf...
third_party/WebKit/PerformanceTests/Layout/resources/line-layout-perf-test.js:36:
this.container.removeChild(this.container.firstChild);
On 2016/08/29 at 16:32:57, eae wrote:
> It's faster the remove the lastChild (but keep checking for firstChild in the
loop condition).

Didn't know that, thank you!

https://codereview.chromium.org/2284113003/diff/40001/third_party/WebKit/Perf...
third_party/WebKit/PerformanceTests/Layout/resources/line-layout-perf-test.js:69:
var fragment = document.createDocumentFragment();
On 2016/08/29 at 16:32:57, eae wrote:
> Any particular reason you're using a document fragment instead of a container
element? Just curious.

In order not to create additional span to wrap, while single appendChild to add
multiple spans. Probably additional span does not matter though.

[kojii, 2016-08-29 19:14:53]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2284113003/#ps60001
(title: "eae review")

[commit-bot: I haz the power, 2016-08-29 19:50:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 04:26:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-30 04:28:10]

Description was changed from

==========
Add performance tests for long words/lines

This patch adds performance tests for:

1. To watch break-all/break-word performance for a very long word,
   which required several fixes in the past.

2. To investigate whitespace collapsing in a long line.

For 1, a test[1] indicates we're linear to the length of the word, but
Gecko/Edge looks consistent and faster than us.

For 2, we're slower than Gecko/Edge by the factor of 10 or so when the
line is very long. I will investigate it further.

[1] http://bl.ocks.org/stestagg/aa6db5d177b09e74825c6e4b02cb3f07

BUG=622810, 583711
==========

to

==========
Add performance tests for long words/lines

This patch adds performance tests for:

1. To watch break-all/break-word performance for a very long word,
   which required several fixes in the past.

2. To investigate whitespace collapsing in a long line.

For 1, a test[1] indicates we're linear to the length of the word, but
Gecko/Edge looks consistent and faster than us.

For 2, we're slower than Gecko/Edge by the factor of 10 or so when the
line is very long. I will investigate it further.

[1] http://bl.ocks.org/stestagg/aa6db5d177b09e74825c6e4b02cb3f07

BUG=622810, 583711

Committed: https://crrev.com/1b56d7b9d53d796b72659d6ea0a70044a74c67ca
Cr-Commit-Position: refs/heads/master@{#415092}
==========

[commit-bot: I haz the power, 2016-08-30 04:28:11]

Patchset 4 (id:??) landed as
https://crrev.com/1b56d7b9d53d796b72659d6ea0a70044a74c67ca
Cr-Commit-Position: refs/heads/master@{#415092}