Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2284113002: [MD settings] change theme label text (Closed)

Created:
4 years, 3 months ago by dschuyler
Modified:
4 years, 3 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] change theme label text This CL changes the label text from Themes to Theme since there is a single theme (not plural). BUG=622786 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d1900650f2f08e845531db6b01c8aafc4365d4d8 Cr-Commit-Position: refs/heads/master@{#415510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
dschuyler
4 years, 3 months ago (2016-08-27 00:20:35 UTC) #4
tommycli
lgtm
4 years, 3 months ago (2016-08-29 16:36:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284113002/1
4 years, 3 months ago (2016-08-29 18:43:50 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/286752)
4 years, 3 months ago (2016-08-30 03:39:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284113002/1
4 years, 3 months ago (2016-08-30 22:53:01 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 00:21:45 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 00:23:57 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1900650f2f08e845531db6b01c8aafc4365d4d8
Cr-Commit-Position: refs/heads/master@{#415510}

Powered by Google App Engine
This is Rietveld 408576698